[Envers] HHH-14263 Skip audit non-insertable, non-updateable components #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgtriffid
changed the title
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
mgtriffid
changed the title
gavinking
changed the title
gavinking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hardly an optimal solution. And maybe straight up wrong. Ideally we should skip these synthetic properties that were created for join during audit here https://github.com/hibernate/hibernate-orm/blob/master/hibernate-envers/src/main/java/org/hibernate/envers/internal/entities/mapper/MultiPropertyMapper.java#L114
However, for some reason propertyData for synthetic property created for join has
isSynthetic == false. And any attempts to drag that value with correct value oftrueended with strange errors way earlier, during metadata generation.https://hibernate.atlassian.net/browse/HHH-14623