HHH-14614 - Better support for JUnit 5 on-failure handling #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context.getExecutableInvoker().invoke( callback, context.getRequiredTestInstance() ); | ||
| } | ||
| catch (Exception e) { | ||
| log.warnf( e, "Error invoking FailureExpectedCallback handling : `%`", callback.getName() ); |
There was a problem hiding this comment.
not 100% sure, but should we use %s placeholder above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHH-14614 - Better support for JUnit 5 on-failure handling
The benefit is this allows us to perform some action when tests fail. E.g., atm we are forced to create and drop test data for each test method -
@BeforeEachand@AfterEach. This support allows us to use@BeforeAlland@AfterAll. Previously this would be a potential problem when tests fail. This support though let's us hook into the "failure process" to rebuild the SessionFactory when we have these failures