Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-16572 - Incorrect enhancement for PROPERTY attributes with mismatched field and method names #6558

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

HHH-16572 - Incorrect enhancement for PROPERTY attributes with mismatched field and method names #6558

wants to merge 5 commits into from

Conversation

sebersole
Copy link
Member

@sebersole
Copy link
Member Author

This first commit is mostly a rough copy of the ClassDetails (and friends) parts of the "annotation source" work. It is a basis for a better understanding of the domain model when deciding what and how to enhance.

Without big changes to EnhancementContext, we are never going to be able to get this 100% correct. And really, the "annotation source" work will make this all faster and even more robust.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2023
View reviewed changes
...ernate/bytecode/enhance/internal/bytebuddy/model/impl/ManagedTypeDescriptorRegistryImpl.java
* @author Steve Ebersole
*/
public class ManagedTypeDescriptorRegistryImpl implements ManagedTypeDescriptorRegistry {
private final Map<String,ManagedTypeDescriptor> managedTypeDescriptorMap = new LinkedHashMap<>();

Check failure

Code scanning / CodeQL

Container contents are never initialized

The contents of this container are never initialized.
...n/java/org/hibernate/bytecode/enhance/internal/bytebuddy/PersistentAttributeTransformer.java
@@ -224,7 +230,9 @@
return null;
}

DynamicType.Builder<?> applyTo(DynamicType.Builder<?> builder) {
DynamicType.Builder<?> applyTo(DynamicType.Builder<?> builder, ManagedTypeModelContext managedTypeModelContext) {
final ManagedTypeDescriptor managedTypeDescriptor = managedTypeModelContext.getDescriptorRegistry().resolveDescriptor( managedCtClass.getName() );

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'ManagedTypeDescriptor managedTypeDescriptor' is never read.
...ernate/bytecode/enhance/internal/bytebuddy/model/impl/ManagedTypeDescriptorRegistryImpl.java
return existing;
}

final ClassDetails classDetails = modelContext.getModelProcessingContext().getClassDetailsRegistry().resolveClassDetails( name );

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'ClassDetails classDetails' is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebersole