Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scope of methods in JdbcEnvironmentInitiator #9871

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Mar 18, 2025

This way Hibernate Reactive can reuse the logic for determining the database version, or the dialect resolution info.

Related to hibernate/hibernate-reactive#2129


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19267

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Mar 18, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

Copy link
Member

@mbladel mbladel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavideD you're missing a digit of the Jira issue in the commit message, other than that this looks fine to merge.

This way Hibernate Reactive can reuse the logic for
determining the database version, or the dialect resolution info.

Related to hibernate/hibernate-reactive#2129
@DavideD
Copy link
Member Author

DavideD commented Mar 18, 2025

Thanks, fixed

@mbladel mbladel merged commit b485b74 into hibernate:main Mar 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants