Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More scope changes in JdbcEnvironmentInitiator #9886

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

More scope changes in JdbcEnvironmentInitiator #9886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f7aac
HHH-19288 Make JdbcEnvironmentInitiator#getJdbcEnvironmentUsingJdbcMe…
DavideD Mar 20, 2025
2da352d
HHH-19288 Move log of connection details to a method
DavideD Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...e-core/src/main/java/org/hibernate/engine/jdbc/env/internal/JdbcEnvironmentInitiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,14 @@ else if ( explicitDialectConfiguration( explicitDatabaseName, configurationValue
databaseConnectionInfo = buildInfo( configurationValues, jdbcEnvironment );
}

logConnectionInfo( databaseConnectionInfo );
return jdbcEnvironment;
}

// For Hibernate Reactive: it needs to disable or customize the log
protected void logConnectionInfo(DatabaseConnectionInfo databaseConnectionInfo) {
// Standardized info logging
ConnectionInfoLogger.INSTANCE.logConnectionInfoDetails( databaseConnectionInfo.toInfoString() );
return jdbcEnvironment;
}

private DatabaseConnectionInfo buildInfo(ServiceRegistryImplementor registry, JdbcEnvironment environment) {
Expand Down Expand Up @@ -324,7 +329,8 @@ private static String getExplicitDatabaseName(Map<String, Object> configurationV
);
}

private JdbcEnvironmentImpl getJdbcEnvironmentUsingJdbcMetadata(
// Used by Hibernate Reactive
protected JdbcEnvironmentImpl getJdbcEnvironmentUsingJdbcMetadata(
Map<String, Object> configurationValues,
ServiceRegistryImplementor registry,
DialectFactory dialectFactory, String explicitDatabaseName,
Expand Down
Loading