Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow (and test) offline startup + on-demand DB version checks #2129

Open
yrodiere opened this issue Feb 18, 2025 · 0 comments
Open

Allow (and test) offline startup + on-demand DB version checks #2129

yrodiere opened this issue Feb 18, 2025 · 0 comments
Assignees
@DavideD
Labels
enhancement New feature or request
Milestone
next

Comments

@yrodiere
Copy link
Member

Hibernate ORM allows starting up without access to the DB ("offline") by specifying hibernate.boot.allow_jdbc_metadata_access = false. When using this setting, Hibernate ORM will not try to reach out to the DB on startup to determine the dialect/version. Instead, it will assume a dialect configured explicitly (e.g. inferred from jakarta.persistence.database-product-name), and either a default version (minimum supported one) or an explicitly configured one (through jakarta.persistence.database-product-version).

This feature is useful in particular for applications that start up before the DB becomes accessible. It can also be useful for Quarkus, where (part of) startup happens at build time.

When this feature is used, it can be useful to check the DB version matches the one that was explicitly configured. Quarkus executes such checks automatically.
However, in some cases, that DB version is not very easy to get, and might require vendor-specific "hacks". That's why Hibernate ORM 7+ exposes Dialect#determineDatabaseVersion: it allows anyone to use the dialect of an already-started-up application to retrieve the version of the DB it's currently connected to, and then do any check they want.

We should check that these features work well in Hibernate Reactive. Copying org.hibernate.orm.test.boot.database.metadata.MetadataAccessTests into the Reactive test suite might be enough for that.

Related: quarkusio/quarkus#43764
@DavideD DavideD self-assigned this Mar 17, 2025
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Mar 18, 2025
@DavideD
HHH-1927 Change scope of methods in JdbcEnvironmentInitiator
5dd92bf 
This is to allow Hibernate Reactive to reuse the logic for
determining the database version.

Related to hibernate/hibernate-reactive#2129
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Mar 18, 2025
@DavideD
HHH-1927 Change scope of methods in JdbcEnvironmentInitiator
163361b 
This way Hibernate Reactive can reuse the logic for
determining the database version, or the dialect resolution info.

Related to hibernate/hibernate-reactive#2129
@DavideD DavideD mentioned this issue Mar 18, 2025
Merged
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Mar 18, 2025
@DavideD
HHH-19267 Change scope of methods in JdbcEnvironmentInitiator
0c13dc0 
This way Hibernate Reactive can reuse the logic for
determining the database version, or the dialect resolution info.

Related to hibernate/hibernate-reactive#2129
mbladel pushed a commit to hibernate/hibernate-orm that referenced this issue Mar 18, 2025
@DavideD @mbladel
HHH-19267 Change scope of methods in JdbcEnvironmentInitiator
b485b74 
This way Hibernate Reactive can reuse the logic for
determining the database version, or the dialect resolution info.

Related to hibernate/hibernate-reactive#2129
@DavideD DavideD added this to the next milestone Mar 18, 2025
@DavideD DavideD added the enhancement New feature or request label Mar 18, 2025
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Mar 20, 2025
@DavideD
HHH-19267 Make JdbcEnvironmentInitiator#getJdbcEnvironmentUsingJdbcMe…
54b6b06 
…tadata protected

For Hibernate Reactive, see issue
hibernate/hibernate-reactive#2129
@DavideD DavideD mentioned this issue Mar 20, 2025
Closed
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Mar 21, 2025
@DavideD
HHH-19267 Make JdbcEnvironmentInitiator#getJdbcEnvironmentUsingJdbcMe…
91f7fc5 
…tadata protected

For Hibernate Reactive, see issue
hibernate/hibernate-reactive#2129
@DavideD DavideD mentioned this issue Mar 21, 2025
Merged
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Mar 21, 2025
@DavideD
[hibernate#2129] Add DatabaseConfiguration#getMinimumVersion
175fca0 
We use it to test the dialect selection at start up
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Mar 21, 2025
@DavideD
[hibernate#2129] Set the logging properties in a separate method
9d7bdd4 
This way we can reuse the method even if the tests don't extend
BaseReactiveTest
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Mar 21, 2025
@DavideD
[hibernate#2129] Remove StandAloneReactiveTest
694bd87 
I'm not sure what's the purpose of this test, and why
it was working before.

But, it doesn't work anymore with the fix for hibernate#2129 because
some properties are missing and we are not setting the right
credentials.

I think it was one of first tests we inroduced when we have created
the project.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Mar 21, 2025
@DavideD
[hibernate#2129] Allow offline startup and on-demand DB version checks
3c857e7 
This feature is useful in particular for applications that start up before the DB becomes accessible.
It can also be useful for Quarkus, where (part of) startup happens at build time.

This achieved by setting the property:

```
hibernate.boot.allow_jdbc_metadata_access = false
```
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Mar 21, 2025
@DavideD
[hibernate#2129] Test hibernate.boot.allow_jdbc_metadata_access
4de56ad 
Hibernate Reactive should be able to start
even if there's no database when
`hibernate.boot.allow_jdbc_metadata_access = false`.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Mar 21, 2025
@DavideD
[hibernate#2129] Test hibernate.boot.allow_jdbc_metadata_access
b094949 
Hibernate Reactive should be able to start
even if there's no database when
`hibernate.boot.allow_jdbc_metadata_access = false`.
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Mar 26, 2025
@DavideD
HHH-19288 Make JdbcEnvironmentInitiator#getJdbcEnvironmentUsingJdbcMe…
a4f7aac 
…tadata protected

For Hibernate Reactive, see issue
hibernate/hibernate-reactive#2129
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Apr 3, 2025
@DavideD
HHH-19288 Make JdbcEnvironmentInitiator#getJdbcEnvironmentUsingJdbcMe…
2d2bf12 
…tadata protected

For Hibernate Reactive, see issue
hibernate/hibernate-reactive#2129
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Apr 4, 2025
@DavideD
HHH-19267 Change scope of methods in JdbcEnvironmentInitiator
cb8630f 
This way Hibernate Reactive can reuse the logic for
determining the database version, or the dialect resolution info.

Related to hibernate/hibernate-reactive#2129
DavideD added a commit to DavideD/hibernate-orm that referenced this issue Apr 4, 2025
@DavideD
HHH-19288 Make JdbcEnvironmentInitiator#getJdbcEnvironmentUsingJdbcMe…
371658a 
…tadata protected

For Hibernate Reactive, see issue
hibernate/hibernate-reactive#2129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
enhancement New feature or request
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@yrodiere @DavideD