Shared session contract #2130
Shared session contract #2130
Conversation
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -28,6 +29,8 @@ | |||
| @Incubating | |||
| public interface ReactiveStatelessSession extends ReactiveQueryProducer, ReactiveSharedSessionContractImplementor { | |||
|
|
|||
| <E,T> CompletionStage<T> reactiveFetch(E entity, Attribute<E,T> field); | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note
|
|
||
| /** | ||
| * Re-read the state of the given instance from the underlying database, | ||
| * requesting the given {@link LockMode}. | ||
| * Create an instance of {@link SelectionQuery} for the given SQL query |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| * <li>If the result set has a single column, the results will be returned | ||
| * as scalars.</li> | ||
| * <li>Otherwise, if the result set has multiple columns, the results will | ||
| * be returned as elements of arrays of type {@code Object[]}.</li> |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
|
Also, please don't move |
|
Also not sure it's a good idea to move |
|
OK, I'm going to revert back the |
DavideD
force-pushed
the
2104-common-shared-contract
branch
from
d1d85a2 to
2e42d90
Compare
Done |
|
By the way, why do we have |
| * {@code session.fetch(book, Book_.isbn).thenAccept(isbn -> print(isbn))} | ||
| * </pre> | ||
| */ | ||
| <E, T> Uni<T> fetch(E entity, Attribute<E, T> field); |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * | ||
| * @throws IllegalArgumentException if the given instance is not managed | ||
| * @see org.hibernate.Hibernate#unproxy(Object) |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
Just avoids an array instantiation in the overwhelmingly more common case that you're only passing one entity. That's unlikely to be a huge overhead, but the overload doesn't cause any problems that I'm aware of. |
A first draft of the shared session contract. I've basically collected the methods we already have in both sessions.
See Mutiny.SharedSessionContract (or Stage.SharedSessionContract).
Personally, I like knowing which methods are not specific to a session.