onChangeTextProp#26
Open
mbyram1 wants to merge 2 commits intohiddentao:masterfrom
Open
Conversation
added 2 commits
November 14, 2018 10:15
…ists that need to make api calls to update
Owner
|
Good idea, but I think it needs architecting a little differently. If user wishes to manually filter then the built-in filtering should be turned off for that. |
|
@hiddentao Are you maintaining this library or not. Can you change or make any appropriate actions for this. Thanks |
Owner
|
@nihp See my previous comment. On this, since the modal already has built-in filtering we'd need to do some work to ensure that's disabled when custom filtering is enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is designed to allow for consumers of this component to get the value of the text being entered. The use case for this is to allow for users to search their api to reload data on longer lists.