fix: add --day option to updateDayListings and remove duplicate --network flag#2320
Open
rockysingh wants to merge 1 commit intohiero-ledger:mainfrom
Open
fix: add --day option to updateDayListings and remove duplicate --network flag#2320rockysingh wants to merge 1 commit intohiero-ledger:mainfrom
rockysingh wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
rockysingh
added
the
Block Node Tools
Nana-EC
previously approved these changes
Mar 5, 2026
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
LG
2 minor non blocking considerations
...sts/tools/src/main/java/org/hiero/block/tools/days/subcommands/UpdateDayListingsCommand.java
Show resolved
Hide resolved
...sts/tools/src/main/java/org/hiero/block/tools/days/subcommands/UpdateDayListingsCommand.java
Show resolved
Hide resolved
rockysingh
force-pushed
the
2154-fix-stale-gcs-listing
branch
from
ee63216 to
bb1b0ce
Compare
…work flag Add --day option to UpdateDayListingsCommand to regenerate the listing for a specific day even if it already exists. This fixes the issue where stale GCS listings (e.g. 2026-02-06 missing entries after 22:46) could not be refreshed without manually deleting the listing file. Remove duplicate --network option from ToWrappedBlocksCommand since it is now inherited from the parent BlockStreamTool via ScopeType.INHERIT. Signed-off-by: Rocky Thind <harpender.t@swirldslabs.com>
rockysingh
force-pushed
the
2154-fix-stale-gcs-listing
branch
from
bb1b0ce to
fea1599
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2320 +/- ##
============================================
- Coverage 80.86% 80.74% -0.12%
Complexity 1459 1459
============================================
Files 139 139
Lines 6766 6766
Branches 728 728
============================================
- Hits 5471 5463 -8
- Misses 976 984 +8
Partials 319 319 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Nana-EC
approved these changes
Mar 5, 2026
tools-and-tests/tools/src/main/java/org/hiero/block/tools/blocks/ToWrappedBlocksCommand.java
Show resolved
Hide resolved
jsync-swirlds
approved these changes
Mar 5, 2026
Contributor
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
Question about the network option; Did you intend to remove that?
Contributor
Author
I've responded in line to the other comment regarding this. It was intended due to inheritance and it was left in there causing an error when running wrap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dayoption toUpdateDayListingsCommandto regenerate the listing for a specific day (e.g.--day 2026-02-06), deleting any existing stale listing first--networkoption fromToWrappedBlocksCommandsince it is now inherited from parent