Skip to content

chore: Use PBJ instead of Google Protobuf library in Otter#21718

Draft
timo0 wants to merge 23 commits intomainfrom
21296-moving-to-pbj
Draft

chore: Use PBJ instead of Google Protobuf library in Otter#21718
timo0 wants to merge 23 commits intomainfrom
21296-moving-to-pbj

Conversation

@timo0
Copy link
Member

@timo0 timo0 commented Oct 17, 2025

Fix #21296

anthony-swirldslabs and others added 14 commits October 16, 2025 14:06
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Co-authored-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 added this to the v0.68 milestone Oct 17, 2025
@timo0 timo0 self-assigned this Oct 17, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 17, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@poulok poulok modified the milestones: v0.68, v0.70 Dec 16, 2025
@Jeffrey-morgan34 Jeffrey-morgan34 modified the milestones: v0.70, v0.71 Jan 8, 2026
timo0 and others added 3 commits January 20, 2026 14:46
Resolve conflicts by keeping PBJ (Protocol Buffer Java) based gRPC
implementation while incorporating new features from main:
- Keep Helidon WebServer and PBJ gRPC clients
- Add timeout_seconds to KillImmediatelyRequest proto
- Improve error logging for premature process termination
- Keep marker file handling for node events
- Merge module dependencies and test configurations

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@codacy-production
Copy link

codacy-production bot commented Jan 20, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eacaf49) 94500 75408 79.80%
Head commit (604295a) 94500 (+0) 75432 (+24) 79.82% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21718) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21718      +/-   ##
============================================
+ Coverage     75.83%   75.85%   +0.02%     
- Complexity    23591    23592       +1     
============================================
  Files          2550     2550              
  Lines         94685    94685              
  Branches      10110    10110              
============================================
+ Hits          71802    71823      +21     
+ Misses        19177    19153      -24     
- Partials       3706     3709       +3     

see 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timo0 added 4 commits January 21, 2026 10:18
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
timo0 added 2 commits January 22, 2026 09:46
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@poulok poulok modified the milestones: v0.71, v0.72 Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate PBJ classes from protobufs in Otter test fixtures

8 participants