chore: Use PBJ instead of Google Protobuf library in Otter#21718
Draft
chore: Use PBJ instead of Google Protobuf library in Otter#21718
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com> Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Co-authored-by: Jendrik Johannes <jendrik.johannes@gmail.com> Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Resolve conflicts by keeping PBJ (Protocol Buffer Java) based gRPC implementation while incorporating new features from main: - Keep Helidon WebServer and PBJ gRPC clients - Add timeout_seconds to KillImmediatelyRequest proto - Improve error logging for premature process termination - Keep marker file handling for node events - Merge module dependencies and test configurations Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21718 +/- ##
============================================
+ Coverage 75.83% 75.85% +0.02%
- Complexity 23591 23592 +1
============================================
Files 2550 2550
Lines 94685 94685
Branches 10110 10110
============================================
+ Hits 71802 71823 +21
+ Misses 19177 19153 -24
- Partials 3706 3709 +3 see 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21296