Conversation
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #21861 +/- ##
============================================
- Coverage 78.28% 78.27% -0.01%
- Complexity 11656 11671 +15
============================================
Files 2461 2463 +2
Lines 92958 93008 +50
Branches 9965 9969 +4
============================================
+ Hits 72769 72799 +30
- Misses 16506 16523 +17
- Partials 3683 3686 +3 ... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
# Conflicts: # hedera-node/hedera-addressbook-service-impl/src/test/java/com/hedera/node/app/service/addressbook/impl/test/handlers/AddressBookTestBase.java # hedera-node/hedera-addressbook-service-impl/src/test/java/com/hedera/node/app/service/addressbook/impl/test/handlers/NodeCreateHandlerTest.java # hedera-node/hedera-addressbook-service-impl/src/test/java/com/hedera/node/app/service/addressbook/impl/test/handlers/NodeDeleteHandlerTest.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
…tion. Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
thenswan
left a comment
There was a problem hiding this comment.
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto LGTM, just a couple of nits
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/record/SystemTransactions.java
...mpl/src/main/java/com/hedera/node/app/service/entityid/impl/schemas/V0720EntityIdSchema.java
Outdated
Show resolved
Hide resolved
# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/utilops/UtilVerbs.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Description:
This PR introduces a new singleton state to track the highest node ID ever used. The change includes:
Related issue(s):
Fixes #18855
Notes for reviewer:
Since the new singleton state is part of
EntityIdStore, a big part of the changes are just mocking or initializing the new singleton for many unit tests.Checklist