Skip to content

Conversation

@ibankov
Copy link
Contributor

@ibankov ibankov commented Oct 28, 2025

Description:

  • Add test that validates the record path dir after node account update.
  • Added node account linking test

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov added this to the v0.68 milestone Oct 28, 2025
@ibankov ibankov self-assigned this Oct 28, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 28, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21891   +/-   ##
=========================================
  Coverage     70.83%   70.83%           
- Complexity    24397    24398    +1     
=========================================
  Files          2667     2667           
  Lines        104253   104253           
  Branches      10955    10955           
=========================================
+ Hits          73843    73844    +1     
  Misses        26362    26362           
+ Partials       4048     4047    -1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 28, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (15d522d) 104158 77846 74.74%
Head commit (b1ea077) 104158 (+0) 77846 (+0) 74.74% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21891) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@ibankov ibankov marked this pull request as ready for review October 28, 2025 17:14
@ibankov ibankov requested review from a team as code owners October 28, 2025 17:14
joshmarinacci
joshmarinacci previously approved these changes Oct 28, 2025
Copy link
Contributor

@joshmarinacci joshmarinacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip869/UpdateAccountEnabledTest.java
Copy link
Contributor

@JivkoKelchev JivkoKelchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibankov ibankov merged commit 1d4d4af into main Nov 4, 2025
62 of 63 checks passed
@ibankov ibankov deleted the record-path-test branch November 4, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants