Skip to content

Conversation

@artemananiev
Copy link
Contributor

Fixes: #21882
Signed-off-by: Artem Ananev [email protected]

@artemananiev artemananiev added this to the v0.69 milestone Oct 29, 2025
@artemananiev artemananiev self-assigned this Oct 29, 2025
@artemananiev artemananiev requested a review from a team as a code owner October 29, 2025 00:40
@artemananiev artemananiev added Platform Virtual Map Platform Tickets pertaining to the platform labels Oct 29, 2025
@lfdt-bot
Copy link

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wirlds/virtualmap/internal/hash/VirtualHasher.java 80.00% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21910      +/-   ##
============================================
+ Coverage     70.58%   70.61%   +0.02%     
- Complexity    24329    24341      +12     
============================================
  Files          2673     2673              
  Lines        104200   104202       +2     
  Branches      10936    10937       +1     
============================================
+ Hits          73547    73579      +32     
+ Misses        26597    26571      -26     
+ Partials       4056     4052       -4     
Files with missing lines Coverage Δ Complexity Δ
...wirlds/virtualmap/internal/hash/VirtualHasher.java 87.11% <80.00%> (+0.11%) 41.00 <1.00> (ø)

... and 23 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a9240a4) 104105 77557 74.50%
Head commit (ea5731a) 104107 (+2) 77585 (+28) 74.52% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21910) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@artemananiev artemananiev merged commit ec4fd33 into main Nov 5, 2025
77 checks passed
@artemananiev artemananiev deleted the 21882-M-virtual-hashing-empty-tree branch November 5, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Virtual Map Platform Tickets pertaining to the platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corner cases for merkle tree hashing

7 participants