-
Notifications
You must be signed in to change notification settings - Fork 179
fix: update request size calculation to include 2 bytes per item #21924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tim Farber-Newman <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
alex-kuzmin-hg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I also will add results of SDLT as ultimate evidence of correctness.
.../hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21924 +/- ##
=========================================
Coverage 70.80% 70.81%
- Complexity 24387 24388 +1
=========================================
Files 2667 2667
Lines 104209 104225 +16
Branches 10944 10945 +1
=========================================
+ Hits 73790 73802 +12
- Misses 26373 26375 +2
- Partials 4046 4048 +2
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
jsync-swirlds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Signed-off-by: Tim Farber-Newman <[email protected]>
Signed-off-by: Tim Farber-Newman <[email protected]>
|
XTS passing: https://github.com/hiero-ledger/hiero-consensus-node/actions/runs/18953850909 except for an Otter test that is not related and the consensus team is aware of. |
Signed-off-by: Tim Farber-Newman <[email protected]>
|
0 errors, all working OK: https://perf.analytics.eng.hashgraph.io/ephemeral/test_runs/timfn/21923-fix-request-size-calculation_AdHoc7_272/report/longevity/podlog_solo-sdlt-n7/ |
petreze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense
.../hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
Show resolved
Hide resolved
) Signed-off-by: Tim Farber-Newman <[email protected]> Signed-off-by: Petar Tonev <[email protected]>
) Signed-off-by: Tim Farber-Newman <[email protected]>
Description:
This updates the size estimation calculation for pending requests we intend to send to a block node to include an extra 2 bytes of overhead per block item.
Also included are some logging enhancements to aid in debugging sending requests to the block node.
Related issue(s):
Fixes #21923
Notes for reviewer:
Checklist