Skip to content

Conversation

@timfn-hg
Copy link
Contributor

Description:
This updates the size estimation calculation for pending requests we intend to send to a block node to include an extra 2 bytes of overhead per block item.

Also included are some logging enhancements to aid in debugging sending requests to the block node.

Related issue(s):

Fixes #21923

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@timfn-hg timfn-hg added this to the v0.68 milestone Oct 29, 2025
@timfn-hg timfn-hg self-assigned this Oct 29, 2025
@timfn-hg timfn-hg requested a review from a team as a code owner October 29, 2025 20:37
@lfdt-bot
Copy link

lfdt-bot commented Oct 29, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

alex-kuzmin-hg
alex-kuzmin-hg previously approved these changes Oct 29, 2025
Copy link
Contributor

@alex-kuzmin-hg alex-kuzmin-hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I also will add results of SDLT as ultimate evidence of correctness.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...app/blocks/impl/streaming/BlockNodeConnection.java 83.33% 0 Missing and 4 partials ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21924   +/-   ##
=========================================
  Coverage     70.80%   70.81%           
- Complexity    24387    24388    +1     
=========================================
  Files          2667     2667           
  Lines        104209   104225   +16     
  Branches      10944    10945    +1     
=========================================
+ Hits          73790    73802   +12     
- Misses        26373    26375    +2     
- Partials       4046     4048    +2     
Files with missing lines Coverage Δ Complexity Δ
...app/blocks/impl/streaming/BlockNodeConnection.java 90.41% <83.33%> (+0.11%) 80.00 <1.00> (+3.00)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 29, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (90ca691) 104114 77791 74.72%
Head commit (1fc9c3d) 104130 (+16) 77805 (+14) 74.72% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21924) 24 24 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Contributor

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

jsync-swirlds
jsync-swirlds previously approved these changes Oct 30, 2025
Signed-off-by: Tim Farber-Newman <[email protected]>
@timfn-hg
Copy link
Contributor Author

XTS passing: https://github.com/hiero-ledger/hiero-consensus-node/actions/runs/18953850909 except for an Otter test that is not related and the consensus team is aware of.

Signed-off-by: Tim Farber-Newman <[email protected]>
@alex-kuzmin-hg
Copy link
Contributor

Copy link
Contributor

@petreze petreze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense

@timfn-hg timfn-hg merged commit b23cb50 into main Oct 31, 2025
60 of 61 checks passed
@timfn-hg timfn-hg deleted the timfn/21923-fix-request-size-calculation branch October 31, 2025 15:59
petreze pushed a commit that referenced this pull request Nov 3, 2025
mxtartaglia-sl pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PublishStreamRequest size calculation incorrect

8 participants