Skip to content

Conversation

@lpetrovic05
Copy link
Contributor

@lpetrovic05 lpetrovic05 commented Oct 30, 2025

closes #21913

Note: I also removed an unused variable from the orphan buffer when I saw it.

Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 added this to the v0.68 milestone Oct 30, 2025
@lpetrovic05 lpetrovic05 self-assigned this Oct 30, 2025
@lpetrovic05 lpetrovic05 requested review from a team as code owners October 30, 2025 11:41
@lfdt-bot
Copy link

lfdt-bot commented Oct 30, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...lds/platform/builder/PlatformComponentBuilder.java 0.00% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21932      +/-   ##
============================================
- Coverage     70.83%   70.81%   -0.02%     
+ Complexity    24397    24392       -5     
============================================
  Files          2667     2667              
  Lines        104253   104250       -3     
  Branches      10955    10955              
============================================
- Hits          73843    73827      -16     
- Misses        26362    26377      +15     
+ Partials       4048     4046       -2     
Files with missing lines Coverage Δ Complexity Δ
...lds/platform/event/orphan/DefaultOrphanBuffer.java 94.73% <100.00%> (ø) 24.00 <1.00> (ø)
...lds/platform/builder/PlatformComponentBuilder.java 35.71% <0.00%> (+0.34%) 49.00 <0.00> (ø)

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 30, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (15d522d) 104158 77846 74.74%
Head commit (f252aee) 104155 (-3) 77828 (-18) 74.72% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21932) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

abies
abies previously approved these changes Oct 30, 2025
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/consensus/TestIntake.java
@lpetrovic05 lpetrovic05 merged commit 7f1b306 into main Nov 4, 2025
57 of 61 checks passed
@lpetrovic05 lpetrovic05 deleted the 21913-JMH-test-for-event-creator branch November 4, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JMH test for event creator

6 participants