chore: Otter chaos bot #21937
Open
chore: Otter chaos bot #21937
+861
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Heinrichs <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
poulok
reviewed
Oct 30, 2025
.../consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/chaosbot/ChaosBot.java
Outdated
Show resolved
Hide resolved
.../src/testFixtures/java/org/hiero/otter/fixtures/chaosbot/internal/NodeFailureExperiment.java
Outdated
Show resolved
Hide resolved
...ests/src/testFixtures/java/org/hiero/otter/fixtures/chaosbot/internal/ExperimentFactory.java
Show resolved
Hide resolved
...otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/turtle/TurtleTestEnvironment.java
Show resolved
Hide resolved
Signed-off-by: Michael Heinrichs <[email protected]>
# Conflicts: # platform-sdk/consensus-otter-tests/src/testFixtures/java/module-info.java
Signed-off-by: Michael Heinrichs <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21937 +/- ##
=========================================
Coverage 70.94% 70.94%
Complexity 24432 24432
=========================================
Files 2668 2668
Lines 104336 104336
Branches 10955 10955
=========================================
Hits 74019 74019
Misses 26274 26274
Partials 4043 4043 🚀 New features to boost your workflow:
|
poulok
previously approved these changes
Nov 6, 2025
Signed-off-by: Michael Heinrichs <[email protected]>
poulok
approved these changes
Nov 7, 2025
| public void runChaos(@NonNull final Duration duration) { | ||
| final Network network = env.network(); | ||
| final TimeManager timeManager = env.timeManager(); | ||
| final Instant endTime = timeManager.now().plus(duration); |
Contributor
There was a problem hiding this comment.
nit: I suggest calling this chaosEndTime so as to distinguish it more from the endTime of each experiment.
| new PriorityQueue<>(Comparator.comparing(Experiment::endTime)); | ||
| Instant nextStart = calculateNextStart(randotron, timeManager.now()); | ||
|
|
||
| while (timeManager.now().isBefore(endTime)) { |
Contributor
There was a problem hiding this comment.
nit: Some simple comments in this method would help readers understand more quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the first version of a chaos bot for Otter. It can be used to generate random failures (network and node). The behavior is deterministic for a fixed seed. This is just a first prototype. The final API will be discussed.
Related issue(s):
Fixes #21921