Skip to content

Conversation

@lpetrovic05
Copy link
Contributor

closes #21302

Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>

# Conflicts:
#	platform-sdk/consensus-otter-tests/src/testOtter/java/org/hiero/otter/test/QuiescenceTest.java
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 added this to the v0.68 milestone Oct 31, 2025
@lpetrovic05 lpetrovic05 requested review from netopyr and poulok October 31, 2025 11:55
@lpetrovic05 lpetrovic05 self-assigned this Oct 31, 2025
@lpetrovic05 lpetrovic05 requested a review from a team as a code owner October 31, 2025 11:55
@lfdt-bot
Copy link

lfdt-bot commented Oct 31, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Oct 31, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (15d522d) 104158 77846 74.74%
Head commit (13c9cb5) 104161 (+3) 77800 (-46) 74.69% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21945) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 requested a review from poulok November 3, 2025 13:36
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21945      +/-   ##
============================================
- Coverage     70.83%   70.78%   -0.05%     
+ Complexity    24397    24387      -10     
============================================
  Files          2667     2667              
  Lines        104253   104256       +3     
  Branches      10955    10955              
============================================
- Hits          73843    73797      -46     
- Misses        26362    26411      +49     
  Partials       4048     4048              
Files with missing lines Coverage Δ Complexity Δ
.../event/creator/impl/tipset/TipsetEventCreator.java 87.97% <100.00%> (+0.20%) 43.00 <0.00> (ø)

... and 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lpetrovic05 lpetrovic05 merged commit 3a16c17 into main Nov 5, 2025
60 of 61 checks passed
@lpetrovic05 lpetrovic05 deleted the 21302-otter-test-quiescence branch November 5, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Otter test for event creator quiescence behaviour

4 participants