Skip to content

Conversation

@Evdokia-Georgieva
Copy link
Contributor

Description:
This PR contains initial negative tests for consensus service with new Simple Fees

Related issue(s):
#20438

…ve-tests

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/fees/SimpleFeesSuite.java
@Evdokia-Georgieva Evdokia-Georgieva added this to the v0.69 milestone Oct 31, 2025
@Evdokia-Georgieva Evdokia-Georgieva self-assigned this Oct 31, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 31, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21947      +/-   ##
============================================
- Coverage     70.82%   70.82%   -0.01%     
+ Complexity    24398    24397       -1     
============================================
  Files          2667     2667              
  Lines        104233   104233              
  Branches      10948    10948              
============================================
- Hits          73826    73825       -1     
  Misses        26359    26359              
- Partials       4048     4049       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 31, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (96ee3ef) 104138 77829 74.74%
Head commit (a43a5a1) 104138 (+0) 77827 (-2) 74.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21947) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@Evdokia-Georgieva Evdokia-Georgieva marked this pull request as ready for review October 31, 2025 17:17
@Evdokia-Georgieva Evdokia-Georgieva requested review from a team as code owners October 31, 2025 17:17
@Evdokia-Georgieva Evdokia-Georgieva merged commit 6e228a8 into main Nov 3, 2025
114 of 117 checks passed
@Evdokia-Georgieva Evdokia-Georgieva deleted the simple-fees-consensus-service-initial-negative-tests branch November 3, 2025 10:10
petreze pushed a commit that referenced this pull request Nov 3, 2025
mxtartaglia-sl pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants