Skip to content

Conversation

@poulok
Copy link
Contributor

@poulok poulok commented Oct 31, 2025

Fixes #21946

Signed-off-by: Kelly Greco <[email protected]>
Signed-off-by: Kelly Greco <[email protected]>
Signed-off-by: Kelly Greco <[email protected]>
Signed-off-by: Kelly Greco <[email protected]>
@poulok poulok added this to the v0.69 milestone Oct 31, 2025
@poulok poulok self-assigned this Oct 31, 2025
@poulok poulok requested a review from a team as a code owner October 31, 2025 15:30
@lfdt-bot
Copy link

lfdt-bot commented Oct 31, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Oct 31, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (759b99c) 104315 78022 74.79%
Head commit (2536f6a) 104315 (+0) 78022 (+0) 74.79% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21951) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21951   +/-   ##
=========================================
  Coverage     70.89%   70.89%           
  Complexity    24428    24428           
=========================================
  Files          2668     2668           
  Lines        104410   104410           
  Branches      10966    10966           
=========================================
  Hits          74021    74021           
  Misses        26343    26343           
  Partials       4046     4046           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artemananiev
Copy link
Contributor

LGTM

Signed-off-by: Kelly Greco <[email protected]>

# Conflicts:
#	platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/turtle/TurtleNode.java
Signed-off-by: Kelly Greco <[email protected]>
@poulok poulok requested a review from netopyr November 5, 2025 19:02
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @poulok

@poulok poulok merged commit 18e1107 into main Nov 5, 2025
64 of 65 checks passed
@poulok poulok deleted the 21946-submit-tx-to-node branch November 5, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an API to submit OtterTransactions to nodes

5 participants