-
Notifications
You must be signed in to change notification settings - Fork 181
build: streamline test setup in otter modules #21953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
6036ae4 to
148d3fb
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21953 +/- ##
============================================
+ Coverage 70.89% 70.91% +0.01%
- Complexity 24424 24431 +7
============================================
Files 2668 2668
Lines 104421 104421
Branches 10965 10965
============================================
+ Hits 74030 74049 +19
+ Misses 26340 26324 -16
+ Partials 4051 4048 -3 see 19 files with indirect coverage changes 🚀 New features to boost your workflow:
|
c991520 to
f273758
Compare
f273758 to
9870619
Compare
9870619 to
6a539d7
Compare
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Jendrik Johannes <[email protected]>
856c492 to
5e81aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome improvement! Much cleaner now. Thanks, @jjohannes
platform-sdk/consensus-otter-tests/src/testIntegration/java/module-info.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- platform-sdk/base-crypto/src/main/java/module-info.java
LGTM.
Description:
Streamline the test setup in otter and ensure that all tests run on the module path.
Related issue(s):
Follow up to #21846 and previous PRs that touched this test setup.
Notes for reviewer:
module-info.javafiles and check added exports --> follow up Clean up exports #21989