Skip to content

Conversation

@jjohannes
Copy link
Contributor

@jjohannes jjohannes commented Oct 31, 2025

Description:

Streamline the test setup in otter and ensure that all tests run on the module path.

Related issue(s):

Follow up to #21846 and previous PRs that touched this test setup.

Notes for reviewer:

@jjohannes jjohannes added this to the v0.70 milestone Oct 31, 2025
@jjohannes jjohannes self-assigned this Oct 31, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 31, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@jjohannes jjohannes force-pushed the otter-build-simplify branch 4 times, most recently from 6036ae4 to 148d3fb Compare November 3, 2025 12:51
@codacy-production
Copy link

codacy-production bot commented Nov 3, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ef884bc) 104326 78036 74.80%
Head commit (5e81aad) 104326 (+0) 78052 (+16) 74.82% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21953) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21953      +/-   ##
============================================
+ Coverage     70.89%   70.91%   +0.01%     
- Complexity    24424    24431       +7     
============================================
  Files          2668     2668              
  Lines        104421   104421              
  Branches      10965    10965              
============================================
+ Hits          74030    74049      +19     
+ Misses        26340    26324      -16     
+ Partials       4051     4048       -3     

see 19 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjohannes jjohannes force-pushed the otter-build-simplify branch 2 times, most recently from c991520 to f273758 Compare November 3, 2025 14:30
@jjohannes jjohannes force-pushed the otter-build-simplify branch from f273758 to 9870619 Compare November 3, 2025 16:37
@netopyr netopyr mentioned this pull request Nov 4, 2025
@jjohannes jjohannes force-pushed the otter-build-simplify branch from 9870619 to 6a539d7 Compare November 5, 2025 08:23
@jjohannes jjohannes force-pushed the otter-build-simplify branch from 856c492 to 5e81aad Compare November 5, 2025 09:41
@jjohannes jjohannes marked this pull request as ready for review November 5, 2025 10:19
@jjohannes jjohannes requested review from a team as code owners November 5, 2025 10:19
@jjohannes jjohannes requested review from nathanklick, netopyr, poulok and timo0 and removed request for nathanklick and poulok November 5, 2025 10:19
@jjohannes jjohannes requested a review from rbarker-dev November 5, 2025 10:20
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement! Much cleaner now. Thanks, @jjohannes

Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • platform-sdk/base-crypto/src/main/java/module-info.java

LGTM.

@jjohannes jjohannes merged commit 15dae91 into main Nov 6, 2025
110 of 114 checks passed
@jjohannes jjohannes deleted the otter-build-simplify branch November 6, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants