Skip to content

Conversation

@stoyanov-st
Copy link
Contributor

Description:

We observed WARN logs for prematurely empty Action Stack with the latest version of CN.
This PR aims to skip the double finalisation that happens in the case of exceptionally halting contract create ops.

Related issue(s):

Fixes #21821

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@stoyanov-st stoyanov-st added this to the v0.69 milestone Oct 31, 2025
@stoyanov-st stoyanov-st self-assigned this Oct 31, 2025
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners October 31, 2025 16:58
@lfdt-bot
Copy link

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ce/contract/impl/exec/tracers/EvmActionTracer.java 66.66% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21955      +/-   ##
============================================
- Coverage     70.80%   70.80%   -0.01%     
- Complexity    24385    24386       +1     
============================================
  Files          2667     2667              
  Lines        104225   104227       +2     
  Branches      10945    10947       +2     
============================================
+ Hits          73797    73798       +1     
- Misses        26379    26381       +2     
+ Partials       4049     4048       -1     
Files with missing lines Coverage Δ Complexity Δ
...ce/contract/impl/exec/tracers/EvmActionTracer.java 94.59% <66.66%> (-5.41%) 18.00 <0.00> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (82d0fd7) 104130 77801 74.72%
Head commit (5e5578c) 104132 (+2) 77801 (+0) 74.71% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21955) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate "Action stack prematurely empty" warning

3 participants