Skip to content

Conversation

@alex-kuzmin-hg
Copy link
Contributor

Description:
Since JDK23, new javadoc warning introduced that fails current CN gradle build with JDK25 compiler.
The fix is to explicitly tell compiler to ignore cases of 'dangling-doc-comments'.

As a reference, there were "uncountable" number of old-style javadoc comments that failed gradle: see
them in diff: main...alexk/JDK25_sources
The suppressing/fixing all individual cases of such comments is less practical.

Related issue(s):

Fixes #22142

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@alex-kuzmin-hg alex-kuzmin-hg requested a review from a team as a code owner November 12, 2025 23:07
@alex-kuzmin-hg alex-kuzmin-hg added this to the v0.70 milestone Nov 12, 2025
@lfdt-bot
Copy link

lfdt-bot commented Nov 12, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@alex-kuzmin-hg alex-kuzmin-hg self-assigned this Nov 12, 2025
@alex-kuzmin-hg alex-kuzmin-hg marked this pull request as draft November 12, 2025 23:46
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d6728f7) 104428 78064 74.75%
Head commit (441ce3e) 104428 (+0) 78064 (+0) 74.75% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22144) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #22144   +/-   ##
=========================================
  Coverage     70.87%   70.87%           
  Complexity    24476    24476           
=========================================
  Files          2682     2682           
  Lines        104523   104523           
  Branches      10972    10972           
=========================================
  Hits          74084    74084           
  Misses        26413    26413           
  Partials       4026     4026           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex-kuzmin-hg alex-kuzmin-hg marked this pull request as ready for review November 13, 2025 05:13
@anthony-swirldslabs
Copy link
Contributor

This is being solved under #20719

and

#21900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JDK25: To update gradle scripts, sources to compile with JDK25

4 participants