chore: 23407 Use computeHash instead of getHash#23408
Open
Conversation
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
artemananiev
previously approved these changes
Feb 6, 2026
thenswan
previously approved these changes
Feb 9, 2026
lpetrovic05
previously approved these changes
Feb 9, 2026
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
imalygin
dismissed stale reviews from lpetrovic05, thenswan, and artemananiev
via
1030400
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #23408 +/- ##
============================================
- Coverage 78.02% 78.01% -0.01%
- Complexity 23404 23405 +1
============================================
Files 2458 2458
Lines 91446 91445 -1
Branches 9707 9707
============================================
- Hits 71353 71345 -8
- Misses 16504 16510 +6
- Partials 3589 3590 +1
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
poulok
reviewed
Feb 9, 2026
| abortAndThrowIfInterrupted( | ||
| initialState::getHash, // calculate hash | ||
| "interrupted while attempting to hash the state"); | ||
| abortAndThrowIfInterrupted(initialState::computeHash, "interrupted while attempting to hash the state"); |
Contributor
There was a problem hiding this comment.
Suggested change
| abortAndThrowIfInterrupted(initialState::computeHash, "interrupted while attempting to hash the state"); | |
| abortAndThrowIfInterrupted(initialState::computeHash, "interrupted while attempting to compute the hash of the state"); |
| // Mock SwirldStateManager | ||
| stateLifecycleManager = mock(StateLifecycleManager.class); | ||
| when(stateLifecycleManager.getMutableState()).thenReturn(testWorkingState); | ||
| when(stateLifecycleManager.getLatestImmutableState()).thenReturn(testWorkingState); |
Contributor
There was a problem hiding this comment.
was this intentional? It seems unrelated to the stated purpose of the PR
poulok
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces usages of
getHashwithcopmuteHashwhere it's appropriateRelated issue(s):
Fixes #23407
Notes for reviewer:
Checklist