Skip to content

fix: fee calculator for Unchecked Submit#23543

Open
joshmarinacci wants to merge 15 commits intomainfrom
enable-more-transcations
Open

fix: fee calculator for Unchecked Submit#23543
joshmarinacci wants to merge 15 commits intomainfrom
enable-more-transcations

Conversation

@joshmarinacci
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci requested a review from a team as a code owner February 11, 2026 20:48
@trunk-io
Copy link

trunk-io bot commented Feb 11, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@joshmarinacci joshmarinacci self-assigned this Feb 11, 2026
@joshmarinacci joshmarinacci added this to the v0.72 milestone Feb 11, 2026
@lfdt-bot
Copy link

lfdt-bot commented Feb 11, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Feb 11, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 31.82%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1f551b8) 91589 75311 82.23%
Head commit (6efb22b) 91610 (+21) 75317 (+6) 82.21% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23543) 22 7 31.82%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...pp/workflows/dispatcher/TransactionDispatcher.java 0.00% 15 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #23543      +/-   ##
============================================
- Coverage     78.25%   78.24%   -0.01%     
- Complexity    23507    23515       +8     
============================================
  Files          2452     2453       +1     
  Lines         91686    91707      +21     
  Branches       9758     9758              
============================================
+ Hits          71749    71757       +8     
- Misses        16326    16341      +15     
+ Partials       3611     3609       -2     
Files with missing lines Coverage Δ Complexity Δ
.../hedera/node/app/workflows/FacilityInitModule.java 38.94% <100.00%> (+0.64%) 20.00 <1.00> (+1.00)
.../service/networkadmin/impl/NetworkServiceImpl.java 100.00% <100.00%> (ø) 4.00 <1.00> (+1.00)
.../impl/calculator/UncheckedSubmitFeeCalculator.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...pp/workflows/dispatcher/TransactionDispatcher.java 51.79% <0.00%> (-5.81%) 45.00 <0.00> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@joshmarinacci joshmarinacci changed the title fix: Enable more Transactions fix: fee calculator for Unchecked Submit Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants