Skip to content

chore: cherry-pick test fixes from Simple Fees feature branch#23583

Merged
ibankov merged 11 commits intomainfrom
chery-pick-from-feature
Feb 16, 2026
Merged

chore: cherry-pick test fixes from Simple Fees feature branch#23583
ibankov merged 11 commits intomainfrom
chery-pick-from-feature

Conversation

@ibankov
Copy link
Contributor

@ibankov ibankov commented Feb 13, 2026

Description:
Cherry pick test fixes from feature branch and make them work with legacy fees.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@ibankov ibankov added this to the v0.72 milestone Feb 13, 2026
@ibankov ibankov self-assigned this Feb 13, 2026
@trunk-io
Copy link

trunk-io bot commented Feb 13, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Feb 13, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Feb 13, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c0d8682) 91589 75313 82.23%
Head commit (5be4f0c) 91589 (+0) 75308 (-5) 82.22% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#23583) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #23583      +/-   ##
============================================
- Coverage     78.25%   78.25%   -0.01%     
+ Complexity    23508    23507       -1     
============================================
  Files          2452     2452              
  Lines         91686    91686              
  Branches       9758     9758              
============================================
- Hits          71751    71746       -5     
- Misses        16324    16329       +5     
  Partials       3611     3611              

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@ibankov ibankov marked this pull request as ready for review February 13, 2026 14:30
@ibankov ibankov requested review from a team as code owners February 13, 2026 14:30
joshmarinacci
joshmarinacci previously approved these changes Feb 13, 2026
Copy link
Contributor

@joshmarinacci joshmarinacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

gkozyryatskyy
gkozyryatskyy previously approved these changes Feb 13, 2026
Copy link
Contributor

@gkozyryatskyy gkozyryatskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few minor comments.
Overall LGTM for SC team.
Thank you!

@ibankov ibankov dismissed stale reviews from gkozyryatskyy and joshmarinacci via 5be4f0c February 13, 2026 21:36
Copy link
Contributor

@joshmarinacci joshmarinacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved again 👍

Copy link
Contributor

@gkozyryatskyy gkozyryatskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ibankov

@ibankov ibankov merged commit c936c7d into main Feb 16, 2026
73 of 74 checks passed
@ibankov ibankov deleted the chery-pick-from-feature branch February 16, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants