chore: cherry-pick test fixes from Simple Fees feature branch#23583
chore: cherry-pick test fixes from Simple Fees feature branch#23583
Conversation
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23583 +/- ##
============================================
- Coverage 78.25% 78.25% -0.01%
+ Complexity 23508 23507 -1
============================================
Files 2452 2452
Lines 91686 91686
Branches 9758 9758
============================================
- Hits 71751 71746 -5
- Misses 16324 16329 +5
Partials 3611 3611 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
gkozyryatskyy
left a comment
There was a problem hiding this comment.
Added few minor comments.
Overall LGTM for SC team.
Thank you!
...n/java/com/hedera/services/bdd/suites/consensus/AtomicBatchConsensusServiceEndToEndTest.java
Show resolved
Hide resolved
...main/java/com/hedera/services/bdd/suites/contract/ethereum/JumboTransactionsEnabledTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ibankov <[email protected]>
5be4f0c
gkozyryatskyy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @ibankov
Description:
Cherry pick test fixes from feature branch and make them work with legacy fees.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist