fix: block stream translators - resolve flaky receipt mismatches#24042
Draft
AlexKehayov wants to merge 4 commits intomainfrom
Draft
fix: block stream translators - resolve flaky receipt mismatches#24042AlexKehayov wants to merge 4 commits intomainfrom
AlexKehayov wants to merge 4 commits intomainfrom
Conversation
…resolve flaky receipt mismatches Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24042 +/- ##
=========================================
Coverage 78.28% 78.28%
Complexity 11662 11662
=========================================
Files 2461 2461
Lines 92960 92960
Branches 9966 9966
=========================================
Hits 72778 72778
Misses 16505 16505
Partials 3677 3677 🚀 New features to boost your workflow:
|
…missing Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes flaky TransactionRecordParityValidator failures where block stream validation reports mismatches between generated and translated records.
Root cause:
BaseTranslator.nextCreatedNum() returns entity numbers in ascending sorted order. When multiple entities of the same type are created in a single transactional unit (e.g., an auto-created account 1946 and a contract 1970), the translator for the contract pops 1946 instead of 1970, producing a wrong contractNum in the receipt. Similarly, TopicCreateTranslator could get the wrong topic number and fail to match any state change, leaving topicID missing from the receipt.
Fix:
Fixes #20489