Skip to content

chore: Add non-zero service fee for queries#24043

Merged
Neeharika-Sompalli merged 7 commits intomainfrom
add-non-zero-service-fee-queries
Mar 6, 2026
Merged

chore: Add non-zero service fee for queries#24043
Neeharika-Sompalli merged 7 commits intomainfrom
add-non-zero-service-fee-queries

Conversation

@Neeharika-Sompalli
Copy link
Contributor

Summary

This PR enables non-zero simple fees for core query operations and adds test coverage to verify node payment behavior for queries.

Key changes:

  • Updated all environments simpleFeesSchedules.json with :
  • Set query base fee to 84 tinycents for non-free queries
  • Mark explicitly free queries:
    • CryptoGetAccountBalance (free: true)
    • TransactionGetReceipt (free: true)
  • Restore SystemDelete and SystemUndelete entries in Network schedule.
  • Update ContractCallLocal simple fee schedule to:
    • baseFee: 41600000
    • extras: [{ "name": "GAS", "includedCount": 50000 }]

Test updates

Added query node-payment assertions to prevent regressions where queries charge USD but do not transfer node payment.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@trunk-io
Copy link

trunk-io bot commented Mar 5, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.73 milestone Mar 5, 2026
@lfdt-bot
Copy link

lfdt-bot commented Mar 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

aderevets
aderevets previously approved these changes Mar 5, 2026
@codacy-production
Copy link

codacy-production bot commented Mar 5, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a9460cb) 92863 76410 82.28%
Head commit (82e58a2) 92863 (+0) 76404 (-6) 82.28% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24043) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #24043      +/-   ##
============================================
- Coverage     78.29%   78.28%   -0.01%     
  Complexity    11662    11662              
============================================
  Files          2461     2461              
  Lines         92960    92960              
  Branches       9965     9965              
============================================
- Hits          72782    72775       -7     
- Misses        16502    16508       +6     
- Partials       3676     3677       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
joshmarinacci
joshmarinacci previously approved these changes Mar 5, 2026
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli and others added 2 commits March 5, 2026 14:33
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
aderevets
aderevets previously approved these changes Mar 5, 2026
tinker-michaelj
tinker-michaelj previously approved these changes Mar 5, 2026
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @Neeharika-Sompalli !

akdev
akdev previously approved these changes Mar 6, 2026
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @Neeharika-Sompalli !

@Neeharika-Sompalli Neeharika-Sompalli merged commit 8556546 into main Mar 6, 2026
115 of 121 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the add-non-zero-service-fee-queries branch March 6, 2026 17:38
aderevets pushed a commit that referenced this pull request Mar 6, 2026
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: aderevets <artem.derevets@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants