chore: Add non-zero service fee for queries#24043
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24043 +/- ##
============================================
- Coverage 78.29% 78.28% -0.01%
Complexity 11662 11662
============================================
Files 2461 2461
Lines 92960 92960
Branches 9965 9965
============================================
- Hits 72782 72775 -7
- Misses 16502 16508 +6
- Partials 3676 3677 +1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
tinker-michaelj
left a comment
There was a problem hiding this comment.
LGTM, tyvm @Neeharika-Sompalli !
166c59b
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
tinker-michaelj
left a comment
There was a problem hiding this comment.
LGTM, tyvm @Neeharika-Sompalli !
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: aderevets <artem.derevets@limechain.tech>
Summary
This PR enables non-zero simple fees for core query operations and adds test coverage to verify node payment behavior for queries.
Key changes:
simpleFeesSchedules.jsonwith :Test updates
Added query node-payment assertions to prevent regressions where queries charge USD but do not transfer node payment.