feat: Full test support and finetuning of the implementation#24045
Draft
petreze wants to merge 27 commits intohip1137-feature-branchfrom
Draft
feat: Full test support and finetuning of the implementation#24045petreze wants to merge 27 commits intohip1137-feature-branchfrom
petreze wants to merge 27 commits intohip1137-feature-branchfrom
Conversation
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
…9-extend-dab-txns # Conflicts: # hedera-node/hedera-addressbook-service-impl/src/test/java/com/hedera/node/app/service/addressbook/impl/test/handlers/NodeCreateHandlerTest.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip1137/RegisteredNodeTest.java
Signed-off-by: Petar Tonev <[email protected]>
…9-extend-dab-txns
Signed-off-by: Petar Tonev <[email protected]>
…ld (#24029) Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
…tuning' into HIP-1137
Signed-off-by: Petar Tonev <[email protected]>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
15 tasks
Signed-off-by: Petar Tonev <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## hip1137-feature-branch #24045 +/- ##
============================================================
- Coverage 78.31% 78.30% -0.02%
+ Complexity 11765 11762 -3
============================================================
Files 2472 2472
Lines 93262 93265 +3
Branches 10004 10003 -1
============================================================
- Hits 73040 73028 -12
- Misses 16532 16548 +16
+ Partials 3690 3689 -1
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
PBJ and old protobuf produce incompatible wire formats for CurrentAndNextFeeSchedule. RegisteredNode fee entries in the old-format feeSchedules.json cause InvalidProtocolBufferException (truncatedMessage) in embedded mode when FeesAndRatesProvider parses PBJ-serialized bytes with old protobuf's CurrentAndNextFeeSchedule.parseFrom(). RegisteredNode fees are already served through simpleFeesSchedules.json which uses PBJ-native serialization, so the old-format entries are unnecessary. Reverts the feeSchedules.json changes from commit 022d3e3. Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
This reverts commit 243cca3. Signed-off-by: Petar Tonev <[email protected]>
696d225 to
0efbb0e
Compare
Signed-off-by: Petar Tonev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR aims to polish the implementation and finalize it. Majority of the
test-clientsDSL is already supported as part of the previous HIP issuesRegisteredNodeTestsuite test class. Also,AtomicBatch,GovernanceTransactionsandScheduleTransactionsconcepts are added in the mix with the 3 new transaction types from HIP-1137Related issue(s):
Fixes #23470
Notes for reviewer:
Checklist