Skip to content

feat: Full test support and finetuning of the implementation#24045

Draft
petreze wants to merge 27 commits intohip1137-feature-branchfrom
23470-full-test-support-and-finetuning
Draft

feat: Full test support and finetuning of the implementation#24045
petreze wants to merge 27 commits intohip1137-feature-branchfrom
23470-full-test-support-and-finetuning

Conversation

@petreze
Copy link
Contributor

@petreze petreze commented Mar 5, 2026

Description:
This PR aims to polish the implementation and finalize it. Majority of the test-clients DSL is already supported as part of the previous HIP issues

  • Some more tests are added to the RegisteredNodeTest suite test class. Also, AtomicBatch, GovernanceTransactions and ScheduleTransactions concepts are added in the mix with the 3 new transaction types from HIP-1137

Related issue(s):

Fixes #23470

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

petreze added 17 commits March 4, 2026 18:12
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
…9-extend-dab-txns

# Conflicts:
#	hedera-node/hedera-addressbook-service-impl/src/test/java/com/hedera/node/app/service/addressbook/impl/test/handlers/NodeCreateHandlerTest.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip1137/RegisteredNodeTest.java
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
@petreze petreze self-assigned this Mar 5, 2026
@petreze petreze requested review from a team as code owners March 5, 2026 16:39
@trunk-io
Copy link

trunk-io bot commented Mar 5, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Mar 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@petreze petreze marked this pull request as draft March 5, 2026 16:39
@petreze petreze linked an issue Mar 5, 2026 that may be closed by this pull request
15 tasks
@codacy-production
Copy link

codacy-production bot commented Mar 5, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 60.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (11c55fc) 93165 76681 82.31%
Head commit (cc4a3fe) 93168 (+3) 76668 (-13) 82.29% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24045) 5 3 60.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rvice/entityid/impl/ReadableEntityIdStoreImpl.java 0.00% 1 Missing ⚠️
...rvice/entityid/impl/WritableEntityIdStoreImpl.java 0.00% 1 Missing ⚠️

Impacted file tree graph

@@                     Coverage Diff                      @@
##             hip1137-feature-branch   #24045      +/-   ##
============================================================
- Coverage                     78.31%   78.30%   -0.02%     
+ Complexity                    11765    11762       -3     
============================================================
  Files                          2472     2472              
  Lines                         93262    93265       +3     
  Branches                      10004    10003       -1     
============================================================
- Hits                          73040    73028      -12     
- Misses                        16532    16548      +16     
+ Partials                       3690     3689       -1     
Files with missing lines Coverage Δ Complexity Δ
...ava/com/hedera/node/app/hapi/utils/EntityType.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...ook/impl/handlers/RegisteredNodeDeleteHandler.java 97.67% <100.00%> (ø) 15.00 <0.00> (ø)
...rvice/entityid/impl/ReadableEntityIdStoreImpl.java 95.00% <0.00%> (-5.00%) 32.00 <0.00> (ø)
...rvice/entityid/impl/WritableEntityIdStoreImpl.java 94.59% <0.00%> (-2.63%) 20.00 <0.00> (ø)

... and 13 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

petreze added 5 commits March 6, 2026 13:35
PBJ and old protobuf produce incompatible wire formats for
CurrentAndNextFeeSchedule. RegisteredNode fee entries in the old-format
feeSchedules.json cause InvalidProtocolBufferException (truncatedMessage)
in embedded mode when FeesAndRatesProvider parses PBJ-serialized bytes
with old protobuf's CurrentAndNextFeeSchedule.parseFrom().

RegisteredNode fees are already served through simpleFeesSchedules.json
which uses PBJ-native serialization, so the old-format entries are
unnecessary.

Reverts the feeSchedules.json changes from commit 022d3e3.

Signed-off-by: Petar Tonev <[email protected]>
@petreze petreze force-pushed the 23470-full-test-support-and-finetuning branch from 696d225 to 0efbb0e Compare March 6, 2026 15:47
Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HIP-1137: Add test-clients DSL ops + BDD coverage for registered node CRUD

2 participants