refactor: 15946 Removed static fields from VirtualHasher and VirtualNodeCache#24061
Open
refactor: 15946 Removed static fields from VirtualHasher and VirtualNodeCache#24061
VirtualHasher and VirtualNodeCache#24061Conversation
…alNodeCache` Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
|
Merging to
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #24061 +/- ##
=========================================
Coverage 78.28% 78.29%
Complexity 11656 11656
=========================================
Files 2461 2461
Lines 92958 92951 -7
Branches 9965 9962 -3
=========================================
+ Hits 72772 72775 +3
+ Misses 16503 16499 -4
+ Partials 3683 3677 -6
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaced
VirtualNodeCache.cleaningPoolandVirtualHasher.hashingPoolwith object-level fields.Related issue(s):
Fixes #15946
Notes for reviewer:
Checklist