Skip to content

refactor: 15946 Removed static fields from VirtualHasher and VirtualNodeCache#24061

Open
imalygin wants to merge 1 commit intomainfrom
15946-static-fields-removal
Open

refactor: 15946 Removed static fields from VirtualHasher and VirtualNodeCache#24061
imalygin wants to merge 1 commit intomainfrom
15946-static-fields-removal

Conversation

@imalygin
Copy link
Contributor

@imalygin imalygin commented Mar 5, 2026

Description:

This PR replaced VirtualNodeCache.cleaningPool and VirtualHasher.hashingPool with object-level fields.

Related issue(s):

Fixes #15946

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…alNodeCache`

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
@imalygin imalygin added this to the v0.73 milestone Mar 5, 2026
@imalygin imalygin self-assigned this Mar 5, 2026
@imalygin imalygin requested a review from a team as a code owner March 5, 2026 23:38
@trunk-io
Copy link

trunk-io bot commented Mar 5, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@lfdt-bot
Copy link

lfdt-bot commented Mar 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 88.64%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (16910e1) 92861 76407 82.28%
Head commit (54e092f) 92854 (-7) 76404 (-3) 82.28% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24061) 44 39 88.64%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wirlds/virtualmap/internal/hash/VirtualHasher.java 69.23% 4 Missing ⚠️
...ds/virtualmap/internal/cache/VirtualNodeCache.java 95.83% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #24061   +/-   ##
=========================================
  Coverage     78.28%   78.29%           
  Complexity    11656    11656           
=========================================
  Files          2461     2461           
  Lines         92958    92951    -7     
  Branches       9965     9962    -3     
=========================================
+ Hits          72772    72775    +3     
+ Misses        16503    16499    -4     
+ Partials       3683     3677    -6     
Files with missing lines Coverage Δ Complexity Δ
...c/main/java/com/swirlds/virtualmap/VirtualMap.java 76.18% <100.00%> (+0.04%) 0.00 <0.00> (ø)
...ds/virtualmap/internal/cache/VirtualNodeCache.java 77.72% <95.83%> (ø) 0.00 <0.00> (ø)
...wirlds/virtualmap/internal/hash/VirtualHasher.java 86.63% <69.23%> (-0.48%) 0.00 <0.00> (ø)

... and 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix static field initialization from a non-static method in the virtualmap package

2 participants