Add simple error handling to kolla-pull-images script #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Normo
commented
Jan 27, 2026
Normo
commented
- Add set -euo pipefail for strict error handling
- Check return codes of docker pull and push commands
- Track success/failure counts and collect failed image names
- Print summary at end with list of failed images
- Exit with code 1 if any images failed
- Add set -euo pipefail for strict error handling - Check return codes of docker pull and push commands - Track success/failure counts and collect failed image names - Print summary at end with list of failed images - Exit with code 1 if any images failed
This image is required by Kolla-Ansible for OVN SB database relay functionality but was missing from the image list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.