fix(lgsm): stream SteamCMD progress without buffering - #71
Conversation
|
|
@MarcStdt Ready for review. SteamCMD already emitted frequent real progress, but |
druid-infra
left a comment
There was a problem hiding this comment.
Compared this against the generator/template pattern used in the repo. The change itself looks coherent; I left one non-blocking suggestion inline about broadening the regression coverage beyond a single golden example.
There was a problem hiding this comment.
The template + generated YAML changes look consistent, but the new regression only spot-checks arkserver. Since this PR updates all LGSM variants, could we strengthen the test to iterate the generated LGSM scroll set (or otherwise assert the wrapper on every generated file)? That would match the repo’s generated-artifact pattern better and make future generator drift much harder to miss.
Summary
stdbuf -oLSnapshotProgressas the only progress source; no estimates or synthetic valuesWhy
SteamCMD emits real progress frequently, but
uniqbuffered the pipe output. That delayed valid samples and produced the observed long pauses and large jumps. Line buffering forwards each existing progress line immediately without adding a PTY or another progress mechanism.Verification
go test -count=1 ./..../scripts/validate_all_scrolls.shgit diff --checkRelated: highcard-dev/druid-cli#97 and highcard-dev/monorepo#318.