Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use a better way to determine whether we have a built-in dashboard #394

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Dec 26, 2024

Ⅰ. Describe what this PR did

Use a better way to determine whether we have a built-in dashboard, so grafana won't block the start-up of console.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni December 26, 2024 10:37
@CH3CHO CH3CHO requested a review from slievrly as a code owner December 26, 2024 10:37
@CH3CHO CH3CHO force-pushed the fix/builtin-dashboard branch from 2d5058e to a42097f Compare December 26, 2024 12:19
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit c14e12f into higress-group:main Jan 2, 2025
4 checks passed
@CH3CHO CH3CHO deleted the fix/builtin-dashboard branch January 2, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants