Finish early instead of failing when testing a scheme with no tests (t…

…uist#6398) * Finish early instead of failing when running a scheme with no tests * Remove scheme print * Remove redundant test action check
hiltonc · Jun 12, 2024 · 2fd3481 · 2fd3481
1 parent afc5078
commit 2fd3481
Show file tree

Hide file tree

Showing 10 changed files with 582 additions and 508 deletions.
diff --git a/Sources/TuistAutomation/Utilities/BuildGraphInspector.swift b/Sources/TuistAutomation/Utilities/BuildGraphInspector.swift
@@ -1,9 +1,11 @@
 import Foundation
+import Mockable
 import Path
 import TuistCore
 import TuistSupport
 import XcodeGraph
 
+@Mockable
 public protocol BuildGraphInspecting {
     /// Returns the build arguments to be used with the given target.
     /// - Parameter project: Project whose build arguments will be returned.

diff --git a/Sources/TuistAutomationTesting/Utilities/MockBuildGraphInspector.swift b/Sources/TuistAutomationTesting/Utilities/MockBuildGraphInspector.swift
diff --git a/Sources/TuistKit/Commands/TrackableCommand/TrackableCommand.swift b/Sources/TuistKit/Commands/TrackableCommand/TrackableCommand.swift
@@ -43,7 +43,7 @@ public class TrackableCommand: TrackableParametersDelegate {
     public func run() async throws {
         let runId: String
         let timer = clock.startTimer()
-        if var command = command as? HasTrackableParameters & ParsableCommand {
+        if let command = command as? HasTrackableParameters & ParsableCommand {
             type(of: command).analyticsDelegate = self
             runId = command.runId
             self.command = command

diff --git a/Sources/TuistKit/Generator/Generator.swift b/Sources/TuistKit/Generator/Generator.swift
@@ -1,4 +1,5 @@
 import Foundation
+import Mockable
 import Path
 import ProjectDescription
 import TuistCore
@@ -9,6 +10,7 @@ import TuistPlugin
 import TuistSupport
 import XcodeGraph
 
+@Mockable
 public protocol Generating {
     @discardableResult
     func load(path: AbsolutePath) async throws -> Graph

diff --git a/Sources/TuistKit/Services/TestService.swift b/Sources/TuistKit/Services/TestService.swift
@@ -245,7 +245,7 @@ final class TestService { // swiftlint:disable:this type_body_length
         }
 
         if let schemeName {
-            guard let scheme = testableSchemes.first(where: { $0.name == schemeName })
+            guard let scheme = graphTraverser.schemes().first(where: { $0.name == schemeName })
             else {
                 throw TestServiceError.schemeNotFound(
                     scheme: schemeName,
@@ -254,6 +254,8 @@ final class TestService { // swiftlint:disable:this type_body_length
             }
 
             switch (testPlanConfiguration?.testPlan, scheme.testAction?.targets.isEmpty, scheme.testAction?.testPlans?.isEmpty) {
+            case (_, false, _):
+                break
             case (nil, true, _), (nil, nil, _):
                 logger.log(level: .info, "The scheme \(schemeName)'s test action has no tests to run, finishing early.")
                 return

diff --git a/Tests/TuistKitTests/Generator/Mocks/MockGenerator.swift b/Tests/TuistKitTests/Generator/Mocks/MockGenerator.swift