Do not override GCC_PREFIX_HEADER for internal targets (tuist#6388)

hiltonc · Jun 10, 2024 · aeeb19b · aeeb19b
1 parent 0039616
commit aeeb19b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/Sources/TuistGenerator/Mappers/ResourcesProjectMapper.swift b/Sources/TuistGenerator/Mappers/ResourcesProjectMapper.swift
@@ -81,7 +81,8 @@ public class ResourcesProjectMapper: ProjectMapping { // swiftlint:disable:this
             sideEffects.append(sideEffect)
         }
 
-        if target.supportsSources,
+        if project.isExternal,
+           target.supportsSources,
            target.sources.containsObjcFiles,
            target.resources.containsBundleAccessedResources
         {

diff --git a/Tests/TuistGeneratorTests/ProjectMappers/ResourcesProjectMapperTests.swift b/Tests/TuistGeneratorTests/ProjectMappers/ResourcesProjectMapperTests.swift
@@ -416,11 +416,12 @@ final class ResourcesProjectMapperTests: TuistUnitTestCase {
 
         // Then
         let gotTarget = try XCTUnwrap(gotProject.targets.values.sorted().last)
-        verifyObjcBundleAccessor(
-            for: target,
-            gotTarget: gotTarget,
-            gotSideEffects: gotSideEffects
+        XCTAssertEqual(
+            gotTarget.settings?.base["GCC_PREFIX_HEADER"],
+            nil
         )
+        XCTAssertEqual(gotTarget.sources.count, 1)
+        XCTAssertEqual(gotSideEffects.count, 0)
     }
 
     func test_map_when_project_name_has_dashes_in_it_bundle_name_include_dash_for_project_name_and_underscore_for_target_name(