Convert rest of acceptance tests to Swift (tuist#5686)

* Migrate precompiled, run, and scaffold features * Migrate scaffold, init * Convert rest of Cucumber features to Swift * Skip tvOS acceptance tests
hiltonc · Dec 16, 2023 · d336395 · d336395
1 parent 76cf29a
commit d336395
Show file tree

Hide file tree

Showing 73 changed files with 682 additions and 2,157 deletions.
diff --git a/.github/workflows/tuist.yml b/.github/workflows/tuist.yml
@@ -15,7 +15,6 @@ on:
       - '!Sources/**/*.docc'
       - Templates/**
       - Tests/**
-      - features/**
       - fixtures/**
       - .package.resolved
       - .github/workflows/tuist.yml
@@ -25,34 +24,9 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  RUBY_VERSION: '3.0.3'
-  TUIST_STATS_OPT_OUT: true
-  NODE_VERSION: 16.17.0
   TUIST_CONFIG_CLOUD_TOKEN: ${{ secrets.TUIST_CONFIG_CLOUD_TOKEN }}
 
 jobs:
-  release_build:
-    name: Release build with Xcode
-    runs-on: macos-13
-    steps:
-      - uses: actions/checkout@v3
-      - uses: actions/cache@v3
-        name: 'Cache Tuist .build folder'
-        with:
-          path: .build
-          key: ${{ runner.os }}-${{ hashFiles('.xcode-version') }}-spm-v1-${{ hashFiles('Package.resolved') }}-git-${{ github.sha }}
-          restore-keys: |
-            ${{ runner.os }}-${{ hashFiles('.xcode-version') }}-spm-v1-${{ hashFiles('Package.resolved') }}
-            ${{ runner.os }}-${{ hashFiles('.xcode-version') }}-spm-v1
-      - name: Select Xcode for Tuist and Tuistenv
-        run: sudo xcode-select -switch /Applications/Xcode_$(cat .xcode-version).app
-      - name: Build Tuist for release
-        run: swift build -c release --product tuist
-      - name: Build Tuistenv for release
-        run: swift build -c release --product tuistenv
-      - name: Build ProjectDescription for release
-        run: swift build -c release --product ProjectDescription
-
   test:
     name: Test with Xcode
     runs-on: macos-13
@@ -72,7 +46,7 @@ jobs:
       - name: Fetch dependencies
         run: tuist fetch
       - name: Test
-        run: tuist test --no-cache --skip-test-targets TuistBuildAcceptanceTests TuistGenerateAcceptanceTests TuistTestAcceptanceTests
+        run: tuist test --no-cache --skip-test-targets TuistBuildAcceptanceTests TuistGenerateAcceptanceTests TuistTestAcceptanceTests TuistAcceptanceTests
 
   cache-warm:
     name: Cache warm with latest Tuist
@@ -117,17 +91,18 @@ jobs:
         run: tuist cache warm
 
   acceptance_tests:
-    name: ${{ matrix.feature }} acceptance tests with Tuist
+    name: Run ${{ matrix.feature }}
     runs-on: macos-13
     env:
       TUIST_CONFIG_CLOUD_TOKEN: ${{ secrets.TUIST_CONFIG_CLOUD_TOKEN }}
     strategy:
       matrix:
         feature:
           [
-            'Build',
-            'Generate',
-            'Test',
+            'TuistAcceptanceTests',
+            'TuistBuildAcceptanceTests',
+            'TuistGenerateAcceptanceTests',
+            'TuistTestAcceptanceTests',
           ]
     steps:
       - uses: actions/checkout@v4
@@ -148,59 +123,7 @@ jobs:
       - name: Fetch dependencies
         run: tuist fetch
       - name: Run acceptance tests
-        run: tuist test Tuist${{ matrix.feature }}AcceptanceTests
-
-  cucumber_acceptance_tests:
-    name: ${{ matrix.feature }} acceptance tests with Xcode
-    runs-on: macos-13
-    strategy:
-      matrix:
-        feature:
-          [
-            'dependencies',
-            'edit',
-            'graph',
-            'init',
-            'list-targets',
-            'plugins',
-            'precompiled',
-            'run',
-            'scaffold',
-            'tasks',
-            'plugin',
-          ]
-    needs: release_build
-    steps:
-      - uses: actions/checkout@v3
-      - name: Initialize submodules
-        run: |
-          git submodule update --init fixtures/tuist_plugin
-      - name: Select Xcode
-        run: sudo xcode-select -switch /Applications/Xcode_$(cat .xcode-version).app
-      - uses: actions/cache@v3
-        name: 'Cache Tuist .build folder'
-        with:
-          path: .build
-          key: ${{ runner.os }}-${{ hashFiles('.xcode-version') }}-spm-v1-${{ hashFiles('Package.resolved') }}-git-${{ github.sha }}
-          restore-keys: |
-            ${{ runner.os }}-${{ hashFiles('.xcode-version') }}-spm-v1-${{ hashFiles('Package.resolved') }}
-            ${{ runner.os }}-${{ hashFiles('.xcode-version') }}-spm-v1
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ env.RUBY_VERSION }}
-      - uses: actions/cache@v3
-        with:
-          path: vendor/bundle
-          key: ${{ runner.os }}-${{ env.RUBY_VERSION }}-gems-${{ hashFiles('Gemfile.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-${{ env.RUBY_VERSION }}-gems-
-      - name: Bundle install
-        run: |
-          bundle config path vendor/bundle
-          bundle install --jobs 4 --retry 3
-      - name: Run cucumber tests
-        run: FEATURE=features/${{ matrix.feature }}.feature make tuist/acceptance-test
-
+        run: tuist test ${{ matrix.feature }}
   lint:
     name: Lint
     runs-on: macos-13

diff --git a/.rubocop.yml b/.rubocop.yml
diff --git a/.ruby-gemset b/.ruby-gemset
diff --git a/.ruby-version b/.ruby-version
diff --git a/.swiftformat b/.swiftformat
@@ -1,7 +1,7 @@
 # file options
 
 --symlinks ignore
---exclude Tests/XCTestManifests.swift,features,Sources/TuistSupport/Vendored,fixtures/Targets/SlothCreator,Sources/TuistAutomation/XcodeBuild/XcodeBuildController.swift
+--exclude Tests/XCTestManifests.swift,Sources/TuistSupport/Vendored,fixtures/Targets/SlothCreator,Sources/TuistAutomation/XcodeBuild/XcodeBuildController.swift
 --exclude fixtures/tuist_plugin
 --disable hoistAwait
 --disable hoistTry

diff --git a/Gemfile b/Gemfile