tracker: fix byte counter leak in Inflights tracker

This change fixes a bug in the Inflights tracker. The reset() method did not
zero the bytes counter, which could result in a quota "leak" and delayed or
stalled MsgApp sends.

The reset() method is used when the replication flow changes state between
Probe/Replicate/Snapshot. If reset() is not called at an appropriate moment,
when Inflights.Full(), the bytes counter would stay over the budget and stall
the flow.

Signed-off-by: Pavel Kalinnikov <[email protected]>

tracker/inflights.go

@@ -137,6 +137,7 @@ func (in *Inflights) Count() int { return in.count }
 
 // reset frees all inflights.
 func (in *Inflights) reset() {
-	in.count = 0
 	in.start = 0
+	in.count = 0
+	in.bytes = 0
 }

tracker/inflights_test.go

@@ -227,6 +227,28 @@ func TestInflightsFull(t *testing.T) {
 	}
 }
 
+func TestInflightsReset(t *testing.T) {
+	in := NewInflights(10, 1000)
+	// Imitate a semi-realistic flow during which the inflight tracker is
+	// periodically reset to empty. Byte usage must not "leak" across resets.
+	index := uint64(0)
+	for epoch := 0; epoch < 100; epoch++ {
+		in.reset()
+		// Add 5 messages. They should not max out the limit yet.
+		for i := 0; i < 5; i++ {
+			require.False(t, in.Full())
+			index++
+			in.Add(index, 16)
+		}
+		// Ack all but last 2 indices.
+		in.FreeLE(index - 2)
+		require.False(t, in.Full())
+		require.Equal(t, 2, in.Count())
+	}
+	in.FreeLE(index)
+	require.Equal(t, 0, in.Count())
+}
+
 func inflightsBuffer(indices []uint64, sizes []uint64) []inflight {
 	if len(indices) != len(sizes) {
 		panic("len(indices) != len(sizes)")