-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mirror html elements with the :root
's scroll position
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mensions on `document.documentElement`
✅ Deploy Preview for scrollmirror ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hirasso
changed the title
feat: mirror html elements with the root scroll position
feat: mirror html elements with the Dec 26, 2023
:root
's scroll position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds experimental support for mirroring the scroll position between the root and HTML elements.
API
This is being achieved like this: If the library detects either
html
orbody
elements in the providedelements
option, it will normalize the behavior like this:window
document.documentElement
Notes
Demo
https://deploy-preview-18--scrollmirror.netlify.app/root/
TODO
:root
,html
andbody
makes it into the finalelements
arrayChecks
main
branchnpm run format
)npm run test
)Additional information