Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize progress calculation, make logging optional #27

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

hirasso
Copy link
Owner

@hirasso hirasso commented Oct 1, 2024

Description

  • allow a single container (useful for testing the scroll progress)
  • use the first container that currently has some overflow for the progress calculation
  • new option {debug: false}

Checks

  • The PR is submitted to the main branch
  • The code was formatted before pushing (npm run format)
  • All tests are passing (npm run test)

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for scrollmirror ready!

Name Link
🔨 Latest commit db5a59b
🔍 Latest deploy log https://app.netlify.com/sites/scrollmirror/deploys/671229f711136e00081ea619
😎 Deploy Preview https://deploy-preview-27--scrollmirror.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hirasso hirasso changed the title feat: optimize progress calculation feat: optimize progress calculation, make logging optional Oct 18, 2024
@hirasso hirasso merged commit 4e786b7 into main Oct 18, 2024
5 checks passed
@hirasso hirasso deleted the feat/optimize-progress-calculation branch October 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant