Skip to content

Conversation

@zone117x
Copy link
Contributor

@zone117x zone117x commented Dec 9, 2023

@codecov
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0b2f09) 71.26% compared to head (5b9933d) 71.33%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/pox-3-force-unlocks    #1762      +/-   ##
============================================================
+ Coverage                     71.26%   71.33%   +0.07%     
============================================================
  Files                            85       85              
  Lines                         11525    11529       +4     
  Branches                       2516     2519       +3     
============================================================
+ Hits                           8213     8224      +11     
+ Misses                         3162     3155       -7     
  Partials                        150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 9, 2023

Vercel deployment URL: https://stacks-blockchain-1cwbv8hlz-blockstack.vercel.app 🚀

@zone117x zone117x requested review from janniks and rafaelcr December 10, 2023 14:11
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏4️⃣

const revokeStackDbTx = await standByForTxSuccess(revokeTxResult.txId);

const revokeStackResult = decodeClarityValue(revokeStackDbTx.raw_result);
expect(revokeStackResult.repr).toEqual('(ok true)'); // ERR_STACKING_PERMISSION_DENIED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: misleading comment?

@zone117x zone117x merged commit f8b4aa8 into feat/pox-3-force-unlocks Dec 12, 2023
@zone117x zone117x deleted the feat/pox-4-testing branch December 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants