Repository navigation
fix(watch): reject fractional --capture intervals - #292
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Reviewed (docs-currency) — fix matches #291; one advisory note.
changelog.d/fixed-291.md:1says fractional intervals are rejected "as documented", but the only place the positive-integer contract is documented is the stderr usage error (src/cli.ts:182). The README flag table (README.md:129,--capture[=ms]) just says "Interval in milliseconds, default1000". Consider appending "(positive integer)" to that README cell so the user-facing docs state the constraint the CLI now enforces. Non-blocking.
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: pushed the README note from the docs-currency review ( 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #291
--capture=<ms>validated the interval withNumber.isFinite, so fractional values such as--capture=1.5were accepted despite the usage error promising a positive integer number of milliseconds. The guard now usesNumber.isInteger, with a test mirroring the existing empty---capture=case.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88