Repository navigation
fix: keep positional text equal to the session name in send --session - #302
Merged
Merged
Conversation
cmdSend decided whether the first positional was the session by comparing values, so 'pluk-send --session=foo foo bar' sent 'bar' and 'pluk-send --session=foo foo' failed with 'text is required'. Key the split off whether --session was supplied instead. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/S
Contributor
Author
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
kubestellar-prow
Bot
added
the
dco-signoff: yes
hivecommons-hive
Bot
removed
the
dco-signoff: yes
kubestellar-prow
Bot
added
the
dco-signoff: yes
hivecommons-hive
Bot
removed
the
dco-signoff: yes
Contributor
Author
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
Contributor
Author
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
hivecommons-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #301
cmdSenddecided whether the first positional argument was the session by comparing it to the resolved session value, so with--session=fooany leading text word equal tofoowas swallowed:The split now keys off whether
--sessionwas supplied. Two regression tests added next to the existingpluk-send --sessioncase intest/cli-branches.test.js; changelog fragmentchangelog.d/fixed-301.md.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88