Repository navigation
ci(publish): narrow workflow-level permissions to contents: read - #305
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
dfe95eb
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
There was a problem hiding this comment.
Looks correct to me; routing to a maintainer because it edits workflow permissions.
Verified at head dfe95eb in .github/workflows/publish.yml:
- Workflow-level block (lines 9–10) is now
contents: readonly;id-token: writeremoved. publishjob (lines 50–52) still declarescontents: read+id-token: writeat job level, so npm provenance/OIDC publishing is unaffected.releasejob (lines 99–100) keepscontents: writefor creating the GitHub release.verify-tag(line 13) declares no job-level block and inheritscontents: read— it only checks out and inspects the tag, so that is sufficient.
Net effect: verify-tag loses an OIDC-capable token it never used. No job loses a permission it needs. Author is the hive App bot; the change is a strict tightening.
Workflow permissions: is a trust surface, so I'm not calling this settled on my own.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @dfe95eb, 7/7 checks green, DCO yes, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
clubanderson
left a comment
There was a problem hiding this comment.
Confirmed — narrowing workflow-level permissions to contents: read is acceptable; publish job retains job-level id-token: write with environment npm, so OIDC publishing is unaffected.
|
/hive decision Confirmed — narrowing workflow-level permissions to contents: read is acceptable; publish job retains job-level id-token: write with environment npm, so OIDC publishing is unaffected. Merge. /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 63f07436ada84fc218c8704fd4ffe076afd58cc6 |
1 similar comment
|
LGTM label has been added. DetailsGit tree hash: 63f07436ada84fc218c8704fd4ffe076afd58cc6 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #304
Narrow the workflow-level
permissionsblock tocontents: readonly, as theid-token: writepermission is only required by thepublishjob, which already declares it in its job-level permissions. This reduces the attack surface by ensuring other jobs likeverify-tagdo not receive unnecessary OIDC-capable tokens.All jobs retain their required permissions:
verify-tag: Uses workflow-levelcontents: readpublish: Uses job-levelcontents: readandid-token: writerelease: Uses job-levelcontents: write— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88