Fix/opcua interruption #1147
Merged
Fix/opcua interruption #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 439 files 439 suites 4m 17s ⏱️ Results for commit 372eb68. ♻️ This comment has been updated with latest results. |
caoccao
approved these changes
Sep 11, 2025
...rc/main/java/com/hivemq/edge/adapters/opcua/listeners/OpcUaSubscriptionLifecycleHandler.java
Outdated
Show resolved
Hide resolved
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #35934
Changes
A connection cutoff results in a transfer of the subscription and monitored items after reconnect.
This seems to always fail and since we were missing a correct onTransferFailed the new connection worked southbound but since no subscriptions were active (transfer had failed) we never got northbound data back.
This PR fixes the problem with a correct implementation of onTransferFailed.