-
Notifications
You must be signed in to change notification settings - Fork 36
Forepic/35771 prelogin notice #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marregui
merged 8 commits into
epic/35771-prelogin-notice
from
forepic/35771-prelogin-notice
Sep 15, 2025
Merged
Forepic/35771 prelogin notice #1148
marregui
merged 8 commits into
epic/35771-prelogin-notice
from
forepic/35771-prelogin-notice
Sep 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 439 files 439 suites 4m 16s ⏱️ Results for commit f435262. ♻️ This comment has been updated with latest results. |
Coverage Report
|
caoccao
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a tiny suggestion.
hivemq-edge/src/main/java/com/hivemq/api/model/components/PreLoginNotice.java
Outdated
Show resolved
Hide resolved
caoccao
approved these changes
Sep 12, 2025
hivemq-edge/src/main/java/com/hivemq/api/model/components/PreLoginNotice.java
Outdated
Show resolved
Hide resolved
marregui
added a commit
that referenced
this pull request
Sep 16, 2025
Add pre-login notice configuration to admin-api, expose with api/v1/frontend/configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
card: https://hivemq.kanbanize.com/ctrl_board/57/cards/35773/details/
with
the result is:
with config: