Skip to content

Conversation

marregui
Copy link
Contributor

card: https://hivemq.kanbanize.com/ctrl_board/57/cards/35773/details/

with

curl http://localhost:8080/api/v1/frontend/configuration

the result is:

 "extensions" : {
    "items" : [ {
      "id" : "hivemq-allow-all-extension",
      "version" : "1.0.0",
      "name" : "Allow All Extension",
      "author" : "HiveMQ",
      "priority" : 0,
      "installed" : true
    } ]
  },
  "hivemqId" : "wwtNa",
  "trackingAllowed" : true,
  "preLoginNotice" : {
    "enabled" : true,
    "title" : "Hola",
    "message" : "Me llamo Dora!",
    "consent" : "Si"
  }

with config:

  <admin-api>
        <enabled>true</enabled>
        <listeners>
            <http-listener>
                <port>API_PORT</port>
                <bind-address>127.0.0.1</bind-address>
            </http-listener>
        </listeners>
        <users>
            <user>
                <username>admin</username>
                <password>hivemq</password>
                <roles><role>admin</role></roles>
            </user>
        </users>
        <pre-login-notice>
            <enabled>true</enabled>
             <title>Hola</title>
             <message>Me llamo Dora!</message>
             <consent>Si</consent>
        </pre-login-notice>
    </admin-api>

Copy link

github-actions bot commented Sep 12, 2025

Test Results

  439 files    439 suites   4m 16s ⏱️
3 705 tests 3 702 ✅ 3 💤 0 ❌
3 710 runs  3 707 ✅ 3 💤 0 ❌

Results for commit f435262.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 12, 2025

Coverage Report

Overall Project 64.45%
File Coverage
PreLoginNotice.java 71.74%

@marregui marregui self-assigned this Sep 12, 2025
Copy link
Member

@caoccao caoccao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a tiny suggestion.

@marregui marregui merged commit 57cc13e into epic/35771-prelogin-notice Sep 15, 2025
13 of 18 checks passed
@marregui marregui deleted the forepic/35771-prelogin-notice branch September 15, 2025 05:57
marregui added a commit that referenced this pull request Sep 16, 2025
Add pre-login notice configuration to admin-api, expose with api/v1/frontend/configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants