Port PR 583 from community edition (max packet size evaluation) #1179
+422
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marregui
force-pushed
the
chore/34090-packet-size-matters-after-all
branch
from
d27302e to
6baea60
Compare
Coverage Report
|
caoccao
approved these changes
Sep 25, 2025
Member
caoccao
left a comment
caoccao
left a comment
There was a problem hiding this comment.
It seems the majority of the changes are reformatting. What are the actual changes?
Contributor
Author
the changes come from https://github.com/hivemq/hivemq-community-edition/pull/583/files mainly MQTTMessageDecoder calculates max packet size prior to reading the message |
codepitbull
approved these changes
Sep 25, 2025
codepitbull
force-pushed
the
chore/34090-packet-size-matters-after-all
branch
from
21d08c1 to
52c27b8
Compare
codepitbull
approved these changes
Dec 9, 2025
Member
|
Do we still need this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
card: https://hivemq.kanbanize.com/ctrl_board/57/cards/34090/details/