-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[model] support LFM2.5-Audio with liquid_audio integration #9733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vovanphuc
wants to merge
8
commits into
hiyouga:main
Choose a base branch
from
vovanphuc:feature/add-lfm2.5-audio-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+740
−2
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
63da627
[model] add LFM2AudioPlugin for LFM2.5-Audio support
vovanphuc d9c7a61
[feature] add lfm2_audio template and model registration
vovanphuc 130996f
[model] add LFM2.5-Audio model loader with liquid_audio integration
vovanphuc 2e2062c
[test] add LFM2.5-Audio plugin tests
vovanphuc e36d8ce
[docs] add LFM2.5-Audio to supported models list
vovanphuc 591ebca
[fix] address review feedback for LFM2.5-Audio implementation
vovanphuc 9994ca2
[fix] add _keys_to_ignore_on_save for LFM2.5-Audio model export
vovanphuc 8151738
[fix] support loading merged LFM2.5-Audio models for finetuning
vovanphuc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation for calculating
audio_seq_lengthsassumes all audios in a batch have the same length. It computes a singleseq_lenbased on the padded feature length and applies it to all audio files. This can lead to an incorrect number of placeholder tokens for shorter audio files in a batch with variable-length audios.The fallback path for Hugging Face's
feature_extractoris more robust as it uses theattention_maskto determine the actual length of each audio. I recommend a similar approach here. Please check if theliquid_audioprocessor can return an attention mask or a list of lengths. If not, you might need to compute the sequence lengths based on the lengths of theaudios_regularizedlist before they are padded and passed to theaudio_processor.