-
Notifications
You must be signed in to change notification settings - Fork 8k
[model] support HY-MT model #9746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @isLinXu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Hunyuan Translation Model Version 1.5 into the system, expanding the range of supported translation models. This enhancement allows users to leverage the advanced capabilities of HY-MT1.5, which offers robust mutual translation across numerous languages, optimized performance for edge devices, and features like terminology intervention and contextual translation. The changes include necessary code modifications for template registration and model configuration, alongside documentation updates to reflect the new model's availability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Hunyuan-MT 1.5 models. The changes are generally good, but I've found a critical issue and a few areas for improvement. There's a typo in a special character within the stop_words for the new hunyuan_1_5 template, which could lead to generation failures. I've also suggested some improvements for consistency and better user experience, such as adding a space to the model name in the README files for readability, and appending an -Instruct suffix to the model names in constants.py to enable automatic template selection. Please review the detailed comments.
|
@hiyouga 你好 |
|
@hopkin-ghp |
|
@isLinXu |
Model Introduction
Hunyuan Translation Model Version 1.5 includes a 1.8B translation model, HY-MT1.5-1.8B, and a 7B translation model, HY-MT1.5-7B. Both models focus on supporting mutual translation across 33 languages and incorporating 5 ethnic and dialect variations. Among them, HY-MT1.5-7B is an upgraded version of our WMT25 championship model, optimized for explanatory translation and mixed-language scenarios, with newly added support for terminology intervention, contextual translation, and formatted translation. Despite having less than one-third the parameters of HY-MT1.5-7B, HY-MT1.5-1.8B delivers translation performance comparable to its larger counterpart, achieving both high speed and high quality. After quantization, the 1.8B model can be deployed on edge devices and support real-time translation scenarios, making it widely applicable.
Key Features and Advantages
Create a new file
examples/train_lora/hunyuan_1_5_sft.yamlwith the following content:Used:
fixes #9728