Adding titles for better semantic - Issue hostolab#755

hmartinez69 · Jun 2, 2021 · 36ddc61 · 36ddc61
1 parent 20c4621
commit 36ddc61
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/app/views/layouts/_footer.html.erb b/app/views/layouts/_footer.html.erb
@@ -3,7 +3,7 @@
     <div class="row w-100">
       <div class="col-lg-4 col-md-12 mb-4 mb-md-0">
         <div class="d-flex align-items-start mb-4">
-          <div class="h4 font-weight-bolder <%= @page_pro ? "text-light" : "text-dark" %>">Covidliste</div>
+          <h2 class="h4 font-weight-bolder <%= @page_pro ? "text-light" : "text-dark" %>">Covidliste</h2>
           <% if @page_pro %>
             <span class="ml-2 badge align-top font-weight-light border <%= @page_pro ? "text-light border-light" : "text-dark border-dark" %>" style="font-size: 0.66rem">Pro</span>
             <span class="sr-only">Professionnels de santé</span>

diff --git a/app/views/pages/donateurs.html.erb b/app/views/pages/donateurs.html.erb
@@ -58,10 +58,10 @@
 
   <% if @diamond_orders.any? %>
     <div class="bg-white p-4 shadow-lg mt-4">
-      <div class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
+      <h2 class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
         <span class="mr-lg-3">💎</span>
         <span class="font-weight-bold">Donateurs Diamant</span>
-      </div>
+      </h2>
       <p> Merci à leur don de <span class="text-primary">5000€ et plus.</span> Grâce à chaque contribution :</p>
       <ul class="mb-0">
         <li>🤩 Vous permettez le fonctionnement de Covidliste pendant <strong>10 jours entiers !</strong></li>
@@ -73,10 +73,10 @@
 
   <% if @gold_orders.any? %>
     <div class="bg-white p-4 shadow-lg mt-4">
-      <div class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
+      <h2 class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
         <span class="mr-lg-3">🥇</span>
         <span class="font-weight-bold">Donateurs Or</span>
-      </div>
+      </h2>
       <p> Merci à leur don de <span class="text-primary">1000€ et plus.</span> Grâce à chaque contribution :</p>
       <ul class="mb-0">
         <li>🤩 Vous permettez le fonctionnement de Covidliste pendant <strong>2 jours entiers !</strong></li>
@@ -88,10 +88,10 @@
 
   <% if @silver_orders.any? %>
     <div class="bg-white p-4 shadow-lg mt-4">
-      <div class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
+      <h2 class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
         <span class="mr-lg-3">🥈</span>
         <span class="font-weight-bold">Donateurs Argent</span>
-      </div>
+      </h2>
       <p> Merci à leur don de <span class="text-primary">500€ et plus.</span> Grâce à chaque contribution :</p>
       <ul class="mb-0">
         <li>🏥 <strong>20 nouveaux centres</strong> seront équipés de Covidliste</li>
@@ -103,10 +103,10 @@
 
   <% if @bronze_orders.any? %>
     <div class="bg-white p-4 shadow-lg mt-4">
-      <div class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
+      <h2 class="d-flex align-items-start align-items-lg-center justify-content-start flex-column flex-lg-row font-weight-light text-primary h2 mb-3">
         <span class="mr-lg-3">🥉</span>
         <span class="font-weight-bold">Donateurs Bronze</span>
-      </div>
+      </h2>
       <p> Merci à leur don de <span class="text-primary">150€ et plus.</span> Grâce à chaque contribution :</p>
       <ul class="mb-0">
         <li>🏥 <strong>7 nouveaux centres</strong> seront équipés de Covidliste</li>

diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb
@@ -59,9 +59,9 @@
     <div class="d-flex align-items-center justify-content-between">
       <div class="row">
         <div class="col-12 col-lg-6">
-          <div class="font-weight-bolder text-dark mb-4 h1">Qu’est-ce que
+          <h3 class="font-weight-bolder text-dark mb-4 h1">Qu’est-ce que
             <span class="text-secondary">Covidliste</span> ?
-          </div>
+          </h3>
           <p class="text-justify">
             Covidliste est une initiative bénévole et citoyenne permettant la mise en relation entre des volontaires à
             la vaccination et des professionnels de santé qui disposent de doses de vaccin.
@@ -101,9 +101,9 @@
     <div class="d-flex align-items-center justify-content-between">
       <div class="row">
         <div class="col-12 col-lg-6 order-1 order-lg-0 mt-5 mb-3 mt-lg-0 mb-lg-0 py-0 py-lg-0">
-          <div class="font-weight-bolder text-dark mb-4 h1"><span class="text-secondary">Comment</span> ça
+          <h3 class="font-weight-bolder text-dark mb-4 h1"><span class="text-secondary">Comment</span> ça
             marche ?
-          </div>
+          </h3>
           <div class="d-flex align-items-start mb-4 text-justify">
             <%= image_tag "home/icon-check-circle.svg", loading: "lazy", height: 32, width: 32, alt: "solution 1", class: "d-none d-lg-block mr-2" %>
             <p class="mb-0">
@@ -155,9 +155,9 @@
           </div>
         </div>
         <div class="col-12 col-lg-6 d-flex justify-content-center align-items-start flex-column mt-3 mt-lg-0">
-          <div class="font-weight-bolder text-dark mb-4 h1"><span class="text-secondary">Pourquoi</span> ce
+          <h3 class="font-weight-bolder text-dark mb-4 h1"><span class="text-secondary">Pourquoi</span> ce
             projet ?
-          </div>
+          </h3>
           <p class="mb-0 line-height-lg text-justify">
             <strong>Covidliste se veut être un soutien et complémentaire à
               la <%= link_to "stratégie vaccinale", "https://solidarites-sante.gouv.fr/grands-dossiers/vaccin-covid-19/", target: "_blank" %>
@@ -177,9 +177,9 @@
     <div class="d-flex align-items-center justify-content-between">
       <div class="row">
         <div class="col-12 col-lg-7 order-1 order-lg-0 mt-5 mt-lg-0">
-          <div class="font-weight-bolder text-dark mb-4 h1"><span class="text-secondary">Qui est derrière</span>
+          <h3 class="font-weight-bolder text-dark mb-4 h1"><span class="text-secondary">Qui est derrière</span>
             Covidliste ?
-          </div>
+          </h3>
           <p class="mb-0 text-justify">
             <%= link_to "Martin Daniel", "https://twitter.com/martindaniel4", target: "_blank", rel: "noopener", class: "text-secondary font-weight-bold text-decoration-underline" %>,
             data scientist

diff --git a/app/views/users/shared/_box_cta.html.erb b/app/views/users/shared/_box_cta.html.erb
@@ -1,7 +1,7 @@
 <div class="bg-theme overflow-hidden">
   <div class="container py-5 my-4">
     <div class="text-center">
-      <div class="font-weight-bolder text-light mb-4 h1"><%= title %></div>
+      <h3 class="font-weight-bolder text-light mb-4 h1"><%= title %></h3>
       <p class="text-light mx-auto mb-3" style="max-width: 800px"><%= sanitize text, tags: %w(br) %></p>
       <%= link_to cta_text, cta_href, class: "btn btn-light btn-large font-weight-bold", role: "button", target: cta_target, data: { behavior: cta_href[0] == "#" ? "smooth-scroll-anchor" : "regular-link" } %>
     </div>