Dtspo 22339 enable asset caching and compression in front door #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAzureDevops
requested review from
subtitleuk,
ieuanb74 and
ryanmcalary11
and removed request for
subtitleuk,
ieuanb74 and
ryanmcalary11
Code Review Suggestions
Cost and Carbon Usage Impact:
Summary:The proposed modifications aim to improve code quality, readability, and maintainability while also considering cost and carbon usage efficiency. Providing default values and types for variables enhances predictability, and optimizing content delivery can lead to both cost savings and reduced environmental impact. |
Plan Result (sbox_frontendappgateway - TerraformPlanApply)
Change Result (Click me) # module.frontendappgateway.azurerm_application_gateway.ag[0] will be updated in-place
~ resource "azurerm_application_gateway" "ag" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw"
name = "cft-aks-fe-00-sbox-agw"
tags = {
"application" = "core"
"autoShutdown" = "true"
"builtFrom" = "hmcts/azure-platform-terraform"
"businessArea" = "CFT"
"criticality" = "Low"
"environment" = "sandbox"
"expiresAfter" = "3000-01-01"
"startupMode" = "always"
}
# (8 unchanged attributes hidden)
- probe {
- host = "cft-api-mgmt.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/cft-api-mgmt" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "cft-api-mgmt" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "frontdoor.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/plumclassic" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "plumclassic" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "hmcts-access.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/hmcts-access" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "hmcts-access" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "hmi-apim.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/hmi-apim" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "hmi-apim" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-user-dashboard.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/idam-user-dashboard" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-user-dashboard" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-web-public.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/idam-web-public" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-web-public" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "labs-apps-njs.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/labs-apps-njs" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "labs-apps-njs" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "labs-endakelly-nodejs.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/labs-endakelly-nodejs" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "labs-endakelly-nodejs" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "labs-goldenpath-khaled.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/labs-goldenpath-khaled" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "labs-goldenpath-khaled" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "labs-rhodrif-nodejs.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/labs-rhodrif-nodejs" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "labs-rhodrif-nodejs" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "plum.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/plum" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "plum" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "reformscan.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/reformscan" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "reformscan" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
+ probe {
+ host = "cft-api-mgmt.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "cft-api-mgmt"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "frontdoor.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "plumclassic"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "hmcts-access.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "hmcts-access"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "hmi-apim.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "hmi-apim"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-user-dashboard.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-user-dashboard"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-web-public.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-web-public"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-apps-njs.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-apps-njs"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-endakelly-nodejs.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-endakelly-nodejs"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-goldenpath-khaled.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-goldenpath-khaled"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-rhodrif-nodejs.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-rhodrif-nodejs"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "plum.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "plum"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "reformscan.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "reformscan"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
# (56 unchanged blocks hidden)
}
# module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw|app-gw-storage-account"
name = "app-gw-storage-account"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (5 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
|
Plan Result (sbox_shutter_webapp - TerraformPlanApply)
|
Plan Result (sbox_private_dns - TerraformPlanApply) |
Plan Result (sbox_backendappgateway - TerraformPlanApply)
Change Result (Click me) # module.backendappgateway.azurerm_application_gateway.ag[0] will be updated in-place
~ resource "azurerm_application_gateway" "ag" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw"
name = "cft-aks00-sandbox-agw"
tags = {
"application" = "core"
"autoShutdown" = "true"
"builtFrom" = "hmcts/azure-platform-terraform"
"businessArea" = "CFT"
"criticality" = "Low"
"environment" = "sandbox"
"expiresAfter" = "3000-01-01"
"startupMode" = "always"
}
# (8 unchanged attributes hidden)
- probe {
- host = "bulk-scan-orchestrator-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-orchestrator" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-orchestrator" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "bulk-scan-payment-processor-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-payment-processor" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-payment-processor" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "bulk-scan-processor-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-processor" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-processor" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "bulk-scan-sample-app-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-sample-app" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-sample-app" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "div-emca-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/div-emca" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "div-emca" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "docmosis.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/dg-docmosis" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "dg-docmosis" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "draft-store-service-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/draft-store-service" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "draft-store-service" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "fpl-case-service-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/fpl-case-service" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "fpl-case-service" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-bail-case-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-bail-case-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-bail-case-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-case-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-case-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-case-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-case-documents-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-case-documents-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-case-documents-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-case-notifications-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-case-notifications-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-case-notifications-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-hearings-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-hearings-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-hearings-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-api-sprod.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/idam-api-sprod" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-api-sprod" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-api.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/idam-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-hmcts-access.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/idam-hmcts-access" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-hmcts-access" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold
# ...
# ... The maximum length of GitHub Comment is 65536, so the content is omitted by tfcmt.
# ...
+ unhealthy_threshold = 3
}
+ probe {
+ host = "ia-case-documents-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "ia-case-documents-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "ia-case-notifications-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "ia-case-notifications-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "ia-hearings-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "ia-hearings-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-api-sprod.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-api-sprod"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-api.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-hmcts-access.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-hmcts-access"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-testing-support-api.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-testing-support-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-user-dashboard.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-user-dashboard"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-user-profile-bridge.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-user-profile-bridge"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-web-admin-sprod.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-web-admin-sprod"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-web-admin.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-web-admin"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-apps-njs-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-apps-njs"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-dj-khaled-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-dj-khaled"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "payment-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "payment-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "plum-frontend-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "plum-frontend"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "probate-business-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "probate-business-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "probate-orchestrator-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "probate-orchestrator-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "probate-submit-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "probate-submit-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rd-professional-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rd-professional-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rd-profile-sync-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rd-profile-sync"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rd-user-profile-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rd-user-profile-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "reform-scan-blob-router-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "reform-scan-blob-router"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "reform-scan-notification-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "reform-scan-notification-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rpe-send-letter-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rpe-send-letter-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "sscs-evidence-share-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "sscs-evidence-share"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "sscs-tribunals-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "sscs-tribunals-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
# (193 unchanged blocks hidden)
}
# module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw|app-gw-storage-account"
name = "app-gw-storage-account"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (5 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
|
Plan Result (sbox_apim_appgw - TerraformPlanApply)
Change Result (Click me) # module.app-gw.data.azurerm_monitor_diagnostic_categories.diagnostic_categories will be read during apply
# (depends on a resource or a module with changes pending)
<= data "azurerm_monitor_diagnostic_categories" "diagnostic_categories" {
+ id = (known after apply)
+ log_category_groups = (known after apply)
+ log_category_types = (known after apply)
+ logs = (known after apply)
+ metrics = (known after apply)
+ resource_id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw"
}
# module.app-gw.azurerm_application_gateway.ag[0] will be updated in-place
~ resource "azurerm_application_gateway" "ag" {
id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw"
name = "cft-apim00-sandbox-agw"
tags = {
"application" = "core"
"builtFrom" = "hmcts/azure-platform-terraform"
"businessArea" = "CFT"
"criticality" = "Low"
"environment" = "sandbox"
"expiresAfter" = "3000-01-01"
"startupMode" = "always"
}
# (8 unchanged attributes hidden)
- probe {
- host = "cft-api-mgmt-appgw.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw/probes/cft-api-mgmt-appgw-probe" -> null
- interval = 10 -> null
- minimum_servers = 0 -> null
- name = "cft-api-mgmt-appgw-probe" -> null
- path = "/status-0123456789abcdef" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
+ probe {
+ host = "cft-api-mgmt-appgw.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 10
+ minimum_servers = 0
+ name = "cft-api-mgmt-appgw-probe"
+ path = "/status-0123456789abcdef"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
# (15 unchanged blocks hidden)
}
# module.app-gw.azurerm_monitor_diagnostic_setting.diagnostic_settings[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostic_settings" {
id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw|AppGw"
name = "AppGw"
# (5 unchanged attributes hidden)
~ metric (known after apply)
- metric {
- category = "AllMetrics" -> null
- enabled = true -> null
- retention_policy {
- days = 0 -> null
- enabled = true -> null
}
}
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
Plan Result (sbox_apim - TerraformPlanApply) |
Plan Result (sbox_global - TerraformPlanApply)
Change Result (Click me) # module.premium_front_door.azurerm_cdn_frontdoor_route.routing_rule_A["idam-web-public"] will be updated in-place
~ resource "azurerm_cdn_frontdoor_route" "routing_rule_A" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/lz-sbox-rg/providers/Microsoft.Cdn/profiles/hmcts-sbox/afdEndpoints/hmcts-sbox/routes/idam-web-public"
name = "idam-web-public"
# (12 unchanged attributes hidden)
+ cache {
+ compression_enabled = true
+ content_types_to_compress = []
+ query_string_caching_behavior = "UseQueryString"
+ query_strings = []
}
}
# module.premium_front_door.azurerm_cdn_frontdoor_route.routing_rule_B["idam-web-public"] will be updated in-place
~ resource "azurerm_cdn_frontdoor_route" "routing_rule_B" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/lz-sbox-rg/providers/Microsoft.Cdn/profiles/hmcts-sbox/afdEndpoints/hmcts-sbox/routes/idam-web-publicHttpsRedirect"
name = "idam-web-publicHttpsRedirect"
# (12 unchanged attributes hidden)
+ cache {
+ compression_enabled = true
+ content_types_to_compress = []
+ query_string_caching_behavior = "UseQueryString"
+ query_strings = []
}
}
# module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/lz-sbox-rg/providers/Microsoft.Cdn/profiles/hmcts-sbox|fd-log-analytics-logs-sa"
name = "fd-log-analytics-logs-sa"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (4 unchanged blocks hidden)
}
Plan: 0 to add, 3 to change, 0 to destroy. |
Plan Result (prod_shutter_webapp - TerraformPlanApply)
Change Result (Click me) # module.static_webapp.azurerm_dns_txt_record.zone_validate["adoption"] will be updated in-place
~ resource "azurerm_dns_txt_record" "zone_validate" {
id = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/platform.hmcts.net/TXT/_dnsauth.apply-for-adoption"
name = "_dnsauth.apply-for-adoption"
tags = {}
# (4 unchanged attributes hidden)
- record {
- value = "n3zyn06dl4jk9flktv4d018rxhrrjfm7" -> null
}
+ record {
+ value = "validated"
}
}
# module.static_webapp.azurerm_dns_txt_record.zone_validate["cui-ra"] will be updated in-place
~ resource "azurerm_dns_txt_record" "zone_validate" {
id = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/manage-your-support-for-hmcts-services.service.gov.uk/TXT/_dnsauth"
name = "_dnsauth"
tags = {}
# (4 unchanged attributes hidden)
- record {
- value = "_b0yl28i2r5fnud7easfnlecl30qx1c8" -> null
}
+ record {
+ value = "validated"
}
}
# module.static_webapp.azurerm_dns_txt_record.zone_validate["et-staff-pet"] will be updated in-place
~ resource "azurerm_dns_txt_record" "zone_validate" {
id = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/employmenttribunals.service.gov.uk/TXT/_dnsauth.admin"
name = "_dnsauth.admin"
tags = {}
# (4 unchanged attributes hidden)
- record {
- value = "z51qchxt096p5249j1mxrl120fzf9r0q" -> null
}
+ record {
+ value = "validated"
}
}
# module.static_webapp.azurerm_dns_txt_record.zone_validate["et-syr"] will be updated in-place
~ resource "azurerm_dns_txt_record" "zone_validate" {
id = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/respond-employment-tribunals.service.gov.uk/TXT/_dnsauth.www"
name = "_dnsauth.www"
tags = {}
# (4 unchanged attributes hidden)
- record {
- value = "_14224mgrkc7hcu22ch6szfm8ta3z1aa" -> null
}
+ record {
+ value = "validated"
}
}
# module.static_webapp.azurerm_dns_txt_record.zone_validate["private-law"] will be updated in-place
~ resource "azurerm_dns_txt_record" "zone_validate" {
id = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/apply-to-court-about-child-arrangements-c100.service.gov.uk/TXT/_dnsauth.www"
name = "_dnsauth.www"
tags = {}
# (4 unchanged attributes hidden)
- record {
- value = "_j2gxx1py0szri6b26hf4p8l5qvr0w30" -> null
}
+ record {
+ value = "validated"
}
}
# module.static_webapp.azurerm_dns_txt_record.zone_validate["sscs-ibca"] will be updated in-place
~ resource "azurerm_dns_txt_record" "zone_validate" {
id = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/appeal-infected-blood-compensation-decision.service.gov.uk/TXT/_dnsauth"
name = "_dnsauth"
tags = {}
# (4 unchanged attributes hidden)
- record {
- value = "_hhaakt936xe29qoq5dv29o5aekkxwph" -> null
}
+ record {
+ value = "validated"
}
}
Plan: 0 to add, 6 to change, 0 to destroy.
|
Plan Result (ithc_global - TerraformPlanApply)
Change Result (Click me) # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/62864d44-5da9-4ae9-89e7-0cf33942fa09/resourceGroups/lz-ithc-rg/providers/Microsoft.Cdn/profiles/hmcts-ithc|fd-log-analytics-logs-sa"
name = "fd-log-analytics-logs-sa"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (4 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy. |
NickAzureDevops
force-pushed
the
DTSPO-22339-Enable-asset-caching-and-compression-in-front-door
branch
from
d0d50c4 to
2a29609
Compare
Code Review FeedbackTerraform Module Source
Newline at End of File
Use of Common Tags
Cache Configuration
Compression Settings
Cost and Carbon Usage Evaluation
Please review these suggestions considering the context and specifics of your project requirements. |
Code ReviewBest Practices and Code QualityTerraform Source Reference
Use of Newline at EOF
Security and Cost ImplicationsConsidering the changes involve enabling caching and compression in the front-door configuration and there are no direct security implications highlighted in the provided diff, it’s still critical to ensure:
Cost Implications
Carbon Usage
Recommendations for Carbon Usage Optimization
|
Terraform Module Source Versioning
Security and Performance
Configuration for Environments
Code Consistency
Documentation and Comments
Summary and Cost ImplicationsWhile the changes are geared towards performance improvements, be mindful of the potential cost implications:
|
NickAzureDevops
force-pushed
the
DTSPO-22339-Enable-asset-caching-and-compression-in-front-door
branch
from
04b8e43 to
79df222
Compare
Code Review Recommendations
SummaryThe modifications introduced aim at enabling asset caching and compression which is commendable for performance and cost optimization. Ensuring the use of specific, tagged versions of Terraform modules, providing sensible defaults for caching and compression settings, safeguarding sensitive data, and adhering to best practices for file formatting are crucial for maintaining a secure, efficient, and highly maintainable infrastructure. |
Review of Git DiffTerraform Module Reference
Terraform Variable Management
Best Practices & Security
Additional Improvements
ConclusionWhile the changes introduced in this diff aim at improving performance through caching and compression, attention should be paid to best practices such as version pinning in Terraform modules, addressing TODOs meaningfully, adhering to good file format practices, and ensuring the infrastructure's changes are well documented and monitored. These improvements not only aid in maintainability but can also contribute to cost optimizations and reductions in carbon usage over time. |
NickAzureDevops
force-pushed
the
DTSPO-22339-Enable-asset-caching-and-compression-in-front-door
branch
from
3b0dd6c to
50dcd55
Compare
Code Review RecommendationsTerraform Module Source Pinning
Secure Terraform Practices
Sustainability Considerations
Code Quality and Maintenance
Versioning and Compatibility
Missing New Line at EOF
These recommendations are not exhaustive but are aimed at improving the security, maintainability, and sustainability of the codebase. |
NickAzureDevops
force-pushed
the
DTSPO-22339-Enable-asset-caching-and-compression-in-front-door
branch
from
e1e71d8 to
c6fb0e6
Compare
Terraform Code Review RecommendationsGeneral Practices
Security and Cost Considerations
Carbon Footprint Consideration
|
Code Review FeedbackTerraform Module Source Pinning
Variable Type Specification for Clarity
Handling Optional Values
Newline at End of File
Variable
|
Code Review FeedbackTerraform module version reference
Terraform
|
Code Review Feedback1. Terraform Module Source Pinning
2. Clear Definition of Variables and Defaults
3.
|
Assessment and RecommendationsComponents Global Main Terraform File
Environments Sbox TFVars
Environment Variables Terraform File
Overall, the changes are heading in the right direction by leveraging caching and compression to improve performance. Ensure the configurations are finely tuned, maintained, and reviewed for security and cost benefits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
See DTSPO-22339
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Enable caching and compression on Front Door in the staging environment by configuring the caching_compression in the cache block. other cache attributes are made optional.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Will be Testing this in sandbox before doing it in perfest
Issues Found
Please list any issues found during testing and how they were resolved:
There were some TF issues on code but it is all resolved
Checklist
Deployment Steps
Please provide the steps required to deploy these changes to Azure.
Not required
Additional Information
Please add any other information that is important to this PR, such as screenshots, logs, or links to other related PRs.
FrontDoor Module PR : hmcts/terraform-module-frontdoor#59
Pipeline: https://dev.azure.com/hmcts/PlatformOperations/_build/results?buildId=692204&view=logs&j=fc72dc6b-e2a2-56c3-f0a3-e38bccfb201a&t=139e1e77-8bc1-5e06-a2fe-4f95f481c778
🤖AEP PR SUMMARY🤖
components/global/main.tf🔄premium_front_doormodule to include the reference "DTSPO-22339-Enable-asset-caching-and-compression-in-front-door".environments/sbox/sbox.tfvars✨frontendssection.environments/variables.tf🔄