-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency python to 3.13 #2433
base: master
Are you sure you want to change the base?
Conversation
Review of Git Diff in
|
Plan Result (sbox_private_dns - TerraformPlanApply)
|
Plan Result (sbox_apim - TerraformPlanApply)
|
Plan Result (sbox_global - TerraformPlanApply)
Change Result (Click me) # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/lz-sbox-rg/providers/Microsoft.Cdn/profiles/hmcts-sbox|fd-log-analytics-logs-sa"
name = "fd-log-analytics-logs-sa"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (4 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Plan Result (sbox_apim_appgw - TerraformPlanApply)
Change Result (Click me) # module.app-gw.data.azurerm_monitor_diagnostic_categories.diagnostic_categories will be read during apply
# (depends on a resource or a module with changes pending)
<= data "azurerm_monitor_diagnostic_categories" "diagnostic_categories" {
+ id = (known after apply)
+ log_category_groups = (known after apply)
+ log_category_types = (known after apply)
+ logs = (known after apply)
+ metrics = (known after apply)
+ resource_id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw"
}
# module.app-gw.azurerm_application_gateway.ag[0] will be updated in-place
~ resource "azurerm_application_gateway" "ag" {
id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw"
name = "cft-apim00-sandbox-agw"
tags = {
"application" = "core"
"builtFrom" = "hmcts/azure-platform-terraform"
"businessArea" = "CFT"
"criticality" = "Low"
"environment" = "sandbox"
"expiresAfter" = "3000-01-01"
}
# (8 unchanged attributes hidden)
- probe {
- host = "cft-api-mgmt-appgw.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw/probes/cft-api-mgmt-appgw-probe" -> null
- interval = 10 -> null
- minimum_servers = 0 -> null
- name = "cft-api-mgmt-appgw-probe" -> null
- path = "/status-0123456789abcdef" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
+ probe {
+ host = "cft-api-mgmt-appgw.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 10
+ minimum_servers = 0
+ name = "cft-api-mgmt-appgw-probe"
+ path = "/status-0123456789abcdef"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
# (15 unchanged blocks hidden)
}
# module.app-gw.azurerm_monitor_diagnostic_setting.diagnostic_settings[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostic_settings" {
id = "/subscriptions/ea3a8c1e-af9d-4108-bc86-a7e2d267f49c/resourceGroups/hmcts-hub-sbox-int/providers/Microsoft.Network/applicationGateways/cft-apim00-sandbox-agw|AppGw"
name = "AppGw"
# (5 unchanged attributes hidden)
~ metric (known after apply)
- metric {
- category = "AllMetrics" -> null
- enabled = true -> null
- retention_policy {
- days = 0 -> null
- enabled = true -> null
}
}
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
Plan Result (sbox_shutter_webapp - TerraformPlanApply)
|
Plan Result (sbox_frontendappgateway - TerraformPlanApply)
Change Result (Click me) # module.frontendappgateway.azurerm_application_gateway.ag[0] will be updated in-place
~ resource "azurerm_application_gateway" "ag" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw"
name = "cft-aks-fe-00-sbox-agw"
tags = {
"application" = "core"
"autoShutdown" = "true"
"builtFrom" = "hmcts/azure-platform-terraform"
"businessArea" = "CFT"
"criticality" = "Low"
"environment" = "sandbox"
"expiresAfter" = "3000-01-01"
"startupMode" = "always"
}
# (8 unchanged attributes hidden)
- probe {
- host = "cft-api-mgmt.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/cft-api-mgmt" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "cft-api-mgmt" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "frontdoor.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/plumclassic" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "plumclassic" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "hmcts-access.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/hmcts-access" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "hmcts-access" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "hmi-apim.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/hmi-apim" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "hmi-apim" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-user-dashboard.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/idam-user-dashboard" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-user-dashboard" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-web-public.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/idam-web-public" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-web-public" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "plum.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/plum" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "plum" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "reformscan.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw/probes/reformscan" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "reformscan" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
+ probe {
+ host = "cft-api-mgmt.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "cft-api-mgmt"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "frontdoor.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "plumclassic"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "hmcts-access.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "hmcts-access"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "hmi-apim.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "hmi-apim"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-user-dashboard.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-user-dashboard"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-web-public.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-web-public"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "plum.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "plum"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "reformscan.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "reformscan"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
# (40 unchanged blocks hidden)
}
# module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw|app-gw-storage-account"
name = "app-gw-storage-account"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (5 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
|
Plan Result (sbox_backendappgateway - TerraformPlanApply)
Change Result (Click me) # module.backendappgateway.azurerm_application_gateway.ag[0] will be updated in-place
~ resource "azurerm_application_gateway" "ag" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw"
name = "cft-aks00-sandbox-agw"
tags = {
"application" = "core"
"autoShutdown" = "true"
"builtFrom" = "hmcts/azure-platform-terraform"
"businessArea" = "CFT"
"criticality" = "Low"
"environment" = "sandbox"
"expiresAfter" = "3000-01-01"
"startupMode" = "always"
}
# (8 unchanged attributes hidden)
- probe {
- host = "bulk-scan-orchestrator-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-orchestrator" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-orchestrator" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "bulk-scan-payment-processor-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-payment-processor" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-payment-processor" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "bulk-scan-processor-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-processor" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-processor" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "bulk-scan-sample-app-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/bulk-scan-sample-app" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "bulk-scan-sample-app" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "div-emca-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/div-emca" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "div-emca" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "docmosis.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/dg-docmosis" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "dg-docmosis" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "draft-store-service-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/draft-store-service" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "draft-store-service" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "fpl-case-service-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/fpl-case-service" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "fpl-case-service" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-bail-case-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-bail-case-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-bail-case-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-case-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-case-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-case-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-case-documents-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-case-documents-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-case-documents-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-case-notifications-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-case-notifications-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-case-notifications-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "ia-hearings-api-sandbox.service.core-compute-sandbox.internal" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/ia-hearings-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "ia-hearings-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-api-sprod.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/idam-api-sprod" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-api-sprod" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-api.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/idam-api" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-api" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold = 3 -> null
- match {
- status_code = [
- "200-399",
] -> null
# (1 unchanged attribute hidden)
}
}
- probe {
- host = "idam-hmcts-access.sandbox.platform.hmcts.net" -> null
- id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw/probes/idam-hmcts-access" -> null
- interval = 20 -> null
- minimum_servers = 0 -> null
- name = "idam-hmcts-access" -> null
- path = "/health/liveness" -> null
- pick_host_name_from_backend_http_settings = false -> null
- port = 0 -> null
- protocol = "Http" -> null
- timeout = 15 -> null
- unhealthy_threshold
# ...
# ... The maximum length of GitHub Comment is 65536, so the content is omitted by tfcmt.
# ...
+ unhealthy_threshold = 3
}
+ probe {
+ host = "ia-case-documents-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "ia-case-documents-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "ia-case-notifications-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "ia-case-notifications-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "ia-hearings-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "ia-hearings-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-api-sprod.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-api-sprod"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-api.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-hmcts-access.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-hmcts-access"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-testing-support-api.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-testing-support-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-user-dashboard.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-user-dashboard"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-user-profile-bridge.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-user-profile-bridge"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-web-admin-sprod.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-web-admin-sprod"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "idam-web-admin.sandbox.platform.hmcts.net"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "idam-web-admin"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-apps-njs-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-apps-njs"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "labs-dj-khaled-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "labs-dj-khaled"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "payment-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "payment-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "plum-frontend-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "plum-frontend"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "probate-business-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "probate-business-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "probate-orchestrator-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "probate-orchestrator-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "probate-submit-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "probate-submit-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rd-professional-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rd-professional-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rd-profile-sync-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rd-profile-sync"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rd-user-profile-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rd-user-profile-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "reform-scan-blob-router-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "reform-scan-blob-router"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "reform-scan-notification-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "reform-scan-notification-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "rpe-send-letter-service-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "rpe-send-letter-service"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "sscs-evidence-share-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "sscs-evidence-share"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
+ probe {
+ host = "sscs-tribunals-api-sandbox.service.core-compute-sandbox.internal"
+ id = (known after apply)
+ interval = 20
+ minimum_servers = 0
+ name = "sscs-tribunals-api"
+ path = "/health/liveness"
+ pick_host_name_from_backend_http_settings = false
+ protocol = "Http"
+ timeout = 15
+ unhealthy_threshold = 3
}
# (193 unchanged blocks hidden)
}
# module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
id = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw|app-gw-storage-account"
name = "app-gw-storage-account"
# (6 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (5 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
|
Plan Result (ithc_private_dns - TerraformPlanApply)
|
Plan Result (ithc_apim - TerraformPlanApply)
|
Plan Result (test_cftapps_private_dns - TerraformPlanApply)
|
Plan Result (demo_apim - TerraformPlanApply)
|
Plan Result (prod_private_dns - TerraformPlanApply)
|
Review Recommendations for
|
6320463
to
b14115d
Compare
Recommendations for Improvements1. Specify Exact Version for GitHub ActionsWhile updating the Python version to 3.13 is a good step forward to keep the environment up-to-date, it's also crucial to pin GitHub Actions to an exact version or a commit SHA to avoid unexpected failures if an action is updated. Using a tag as shown can lead to inconsistencies if the tag is moved or updated. Example: Instead of yaml
Or uses: actions/setup-python@abcdef1234567890abcdef1234567890abcdef12 # Example commit SHA 2. Caching Dependencies to Optimize Workflow RunsTo minimize the execution time and reduce cost, consider caching dependencies for the workflow. This is not directly visible from the provided diff but is a general improvement that can significantly affect both cost and c |
b14115d
to
7fc34bb
Compare
Review:
|
7fc34bb
to
95519d9
Compare
Code Review Feedback on
|
95519d9
to
09504b6
Compare
Review of the
|
09504b6
to
a0bc1d8
Compare
Code Review:
|
a0bc1d8
to
ce930b3
Compare
Review SummaryWhile the diff shows a concise change in the Python version used within the workflow, a few improvements and considerations could be added:
Suggestions:
Applying these suggestions provides a more robust, secure, and efficient CI/CD setup with potentially lower costs and environmental impact. |
ce930b3
to
e87c90e
Compare
GitHub Action Workflow Review:
|
e87c90e
to
0e3d69f
Compare
Code Review on Git Diff for
|
0e3d69f
to
2c442cb
Compare
Review Summary:The change to the Python version in the workflow seems to address keeping the project's dependencies up to date, which is a good practice. However, there are a few more improvements that could further enhance the code quality, security, and possibly even cost and carbon usage, depending on the workflow's execution frequency and runtime duration. Below are some specific recommendations: Python Version PrecisionSpecifying Python Suggestion:
Or, for a more cautious approach that still allows automatic patch updates: uses: mikefarah/[email protected] Check for Redundancies and Optimizations
Example: - name: Cache Python packages
uses: actions/cache@v3
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
restore-keys: |
${{ runner.os }}-pip-
Example: on:
push:
paths-ignore:
- '**.md' Financial, Security, and Environmental Impact:
Estimated Price Changes: Direct cost changes in GBP are minimal to none for public repositories, but for private repositories, optimizing workflow execution times can lead to reduced GitHub Actions costs. The actual savings depend on the current usage patterns and GitHub's pricing model at the time of implementation. |
This PR contains the following updates:
3.10
->3.13
Release Notes
actions/python-versions (python)
v3.13.2
: 3.13.2Compare Source
Python 3.13.2
v3.13.1
: 3.13.1Compare Source
Python 3.13.1
v3.13.0
: 3.13.0Compare Source
Python 3.13.0
v3.12.9
: 3.12.9Compare Source
Python 3.12.9
v3.12.8
: 3.12.8Compare Source
Python 3.12.8
v3.12.7
: 3.12.7Compare Source
Python 3.12.7
v3.12.6
: 3.12.6Compare Source
Python 3.12.6
v3.12.5
: 3.12.5Compare Source
Python 3.12.5
v3.12.4
: 3.12.4Compare Source
Python 3.12.4
v3.12.3
: 3.12.3Compare Source
Python 3.12.3
v3.12.2
: 3.12.2Compare Source
Python 3.12.2
v3.12.1
: 3.12.1Compare Source
Python 3.12.1
v3.12.0
: 3.12.0Compare Source
Python 3.12.0
v3.11.11
: 3.11.11Compare Source
Python 3.11.11
v3.11.10
: 3.11.10Compare Source
Python 3.11.10
v3.11.9
: 3.11.9Compare Source
Python 3.11.9
v3.11.8
: 3.11.8Compare Source
Python 3.11.8
v3.11.7
: 3.11.7Compare Source
Python 3.11.7
v3.11.6
: 3.11.6Compare Source
Python 3.11.6
v3.11.5
: 3.11.5Compare Source
Python 3.11.5
v3.11.4
: 3.11.4Compare Source
Python 3.11.4
v3.11.3
: 3.11.3Compare Source
Python 3.11.3
v3.11.2
: 3.11.2Compare Source
Python 3.11.2
v3.11.1
: 3.11.1Compare Source
Python 3.11.1
v3.11.0
: 3.11.0Compare Source
Python 3.11.0
Configuration
📅 Schedule: Branch creation - "after 7am and before 11am every weekday" in timezone Europe/London, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
🤖AEP PR SUMMARY🤖